From 3aa7489c3edf46434776b47d0f3eb16537a7de82 Mon Sep 17 00:00:00 2001 From: Ben Segall Date: Tue, 27 Jun 2023 16:18:53 +0000 Subject: [PATCH] Revert "reclient: Enable racing for chrome developers" This reverts commit 24ac2543c744b2152465ea758671d46d1077bcf9. Reason for revert: hard links dont work on tmpfs b/288997481 Original change's description: > reclient: Enable racing for chrome developers > > racing_bias=0.95 is a best guess based on benchmarks on my glinux and gwindows cloudtops, and my gmac laptop. I will monitor build performance data and adjust the bias based on that. > > Bug: b/288285261 > Change-Id: Ie8652281f7bc815e64978bcd56a75e5ec28e2132 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4633180 > Commit-Queue: Ben Segall > Reviewed-by: Takuto Ikuta Bug: b/288285261 Change-Id: I7b262f63d4edd68447fcec0a781ef55923635d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4651968 Bot-Commit: Rubber Stamper Commit-Queue: Ben Segall --- reclient_helper.py | 8 -------- 1 file changed, 8 deletions(-) diff --git a/reclient_helper.py b/reclient_helper.py index 4c4c8b56e..6b1ff377a 100644 --- a/reclient_helper.py +++ b/reclient_helper.py @@ -165,12 +165,6 @@ def set_reproxy_path_flags(out_dir, make_dirs=True): hashlib.sha256(tmp_dir.encode()).hexdigest()) -def enable_racing(): - os.environ.setdefault("RBE_exec_strategy", "racing") - # TODO(b/288285261) Tune bias once latency data has been gathered. - os.environ.setdefault("RBE_racing_bias", "0.95") - - @contextlib.contextmanager def build_context(argv, tool): # If use_remoteexec is set, but the reclient binaries or configs don't @@ -204,8 +198,6 @@ def build_context(argv, tool): print('WARNING: Using RBE_instance=%s\n' % os.environ.get('RBE_instance', '')) - enable_racing() - reproxy_ret_code = start_reproxy(reclient_cfg, reclient_bin_dir) if reproxy_ret_code != 0: yield reproxy_ret_code