Print access errors using logging.error

https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1058722
changed the behaviour of reporting access errors to no longer
interleave them throughout the output, but instead batch them
together.

This CL had the side effect of changing the way the errors are printed
from using logging.error to print. This means that the errors are now
printing to stdout instead of stderr. This is causing personal scripts
I have for generating reports to fail, since they filtered out stderr.

Change-Id: I664f6166c55f8d20d3c35b63eda695335ab7f8a6
Reviewed-on: https://chromium-review.googlesource.com/1069213
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
changes/13/1069213/2
Ryan Harrison 7 years ago committed by Commit Bot
parent 428e7c14de
commit 398fb44e28

@ -673,7 +673,9 @@ class MyActivity(object):
def print_access_errors(self):
if self.access_errors:
print ('\nAccess Errors:\n%s' % ''.join(self.access_errors))
logging.error('Access Errors:')
for error in self.access_errors:
logging.error(error.rstrip())
def get_reviews(self):
num_instances = len(rietveld_instances) + len(gerrit_instances)

Loading…
Cancel
Save