From 3841eaa164c2f34c8ea969d462a3151b10151780 Mon Sep 17 00:00:00 2001 From: Quinten Yearsley Date: Mon, 23 Sep 2019 21:07:07 +0000 Subject: [PATCH] Remove unused imports in depot_tools/*.py I know that sometimes imports can have side-effects, so unused imports shouldn't always be removed, but these ones look like they could be. Change-Id: Iea9f82afa99b0ea35f29a28f20ce0493b579cfee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1819860 Reviewed-by: Edward Lesmes Commit-Queue: Quinten Yearsley --- buildbucket.py | 1 - gclient_scm.py | 1 - git_cache.py | 2 -- my_activity.py | 1 - ninjalog_uploader.py | 1 - roll_dep.py | 2 -- scm.py | 4 ---- 7 files changed, 12 deletions(-) diff --git a/buildbucket.py b/buildbucket.py index d5b87e9b3d..84b897ca42 100755 --- a/buildbucket.py +++ b/buildbucket.py @@ -22,7 +22,6 @@ import json import urlparse import os import sys -import time from third_party import httplib2 diff --git a/gclient_scm.py b/gclient_scm.py index 457d73f059..007c5164dc 100644 --- a/gclient_scm.py +++ b/gclient_scm.py @@ -24,7 +24,6 @@ try: except ImportError: # For Py3 compatibility import urllib.parse as urlparse -import download_from_google_storage import gclient_utils import git_cache import scm diff --git a/git_cache.py b/git_cache.py index ab3d08926c..6b8cd7f679 100755 --- a/git_cache.py +++ b/git_cache.py @@ -24,8 +24,6 @@ try: except ImportError: # For Py3 compatibility import urllib.parse as urlparse -import zipfile - from download_from_google_storage import Gsutil import gclient_utils import subcommand diff --git a/my_activity.py b/my_activity.py index 21e409d232..5e76cc15fb 100755 --- a/my_activity.py +++ b/my_activity.py @@ -38,7 +38,6 @@ import collections import contextlib from datetime import datetime from datetime import timedelta -from functools import partial import itertools import json import logging diff --git a/ninjalog_uploader.py b/ninjalog_uploader.py index 467ceb8550..3cc18b6726 100755 --- a/ninjalog_uploader.py +++ b/ninjalog_uploader.py @@ -23,7 +23,6 @@ import logging import multiprocessing import os import platform -import socket import subprocess import sys import time diff --git a/roll_dep.py b/roll_dep.py index a41be48120..63fc3ff966 100755 --- a/roll_dep.py +++ b/roll_dep.py @@ -12,8 +12,6 @@ script will always roll to the tip of to origin/master. from __future__ import print_function import argparse -import collections -import gclient_eval import os import re import subprocess diff --git a/scm.py b/scm.py index 39e9b4ea4e..e102e8d107 100644 --- a/scm.py +++ b/scm.py @@ -6,14 +6,10 @@ import glob import io -import logging import os import platform import re import sys -import tempfile -import time -from xml.etree import ElementTree import gclient_utils import subprocess2