From 34a92d91a7b7579eb1164cc5c4b75d460b8e6628 Mon Sep 17 00:00:00 2001 From: "dominik.rottsches@intel.com" Date: Wed, 25 Mar 2015 07:36:05 +0000 Subject: [PATCH] Fine tune const NSClass* presubmit check Blink CL https://codereview.chromium.org/879533003/ defines own casts to convert between bridged types. The cast helpers in base cannot be used in Blink. Fine tune the presubmit check to allow for those by adding a negative look behind for reinterpret_cast. BUG= Review URL: https://codereview.chromium.org/1034523003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294560 0039d316-1c4b-4281-b951-d872f2087c98 --- presubmit_canned_checks.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py index 27cbc4295..49ed07c6f 100644 --- a/presubmit_canned_checks.py +++ b/presubmit_canned_checks.py @@ -948,7 +948,8 @@ def _RietveldOwnerAndReviewers(input_api, email_regexp, approval_needed=False): def _CheckConstNSObject(input_api, output_api, source_file_filter): """Checks to make sure no objective-c files have |const NSSomeClass*|.""" pattern = input_api.re.compile( - r'const\s+NS(?!(Point|Range|Rect|Size)\s*\*)\w*\s*\*') + r'(?