From 172b6e745121be6d527b711ed1dad50e0cd145d8 Mon Sep 17 00:00:00 2001 From: "thestig@chromium.org" Date: Tue, 26 Jan 2010 00:35:03 +0000 Subject: [PATCH] Partial revert of r37053. Put back the gcl default CODEREVIEW_SETTINGS as we had it before, except with an updated CC_LIST. BUG=none TEST=Using gcl from src/third_party/WebKit sends code reviews to codereview.chromium.org. Review URL: http://codereview.chromium.org/552144 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37069 0039d316-1c4b-4281-b951-d872f2087c98 --- gcl.py | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/gcl.py b/gcl.py index f69d81fde..8b1493190 100755 --- a/gcl.py +++ b/gcl.py @@ -28,8 +28,21 @@ __version__ = '1.1.3' CODEREVIEW_SETTINGS = { + # Ideally, we want to set |CODE_REVIEW_SERVER| to a generic server like + # codereview.appspot.com and remove |CC_LIST| and |VIEW_VC|. In practice, we + # need these settings so developers making changes in directories such as + # Chromium's src/third_party/WebKit will send change lists to the correct + # server. + # + # To make gcl send reviews to a different server, check in a file named + # "codereview.settings" (see |CODEREVIEW_SETTINGS_FILE| below) to your + # project's base directory and add the following line to codereview.settings: + # CODE_REVIEW_SERVER: codereview.yourserver.org + # # Default values. - "CODE_REVIEW_SERVER": "codereview.appspot.com", + "CODE_REVIEW_SERVER": "codereview.chromium.org", + "CC_LIST": "chromium-reviews@chromium.org", + "VIEW_VC": "http://src.chromium.org/viewvc/chrome?view=rev&revision=", } # globals that store the root of the current repository and the directory where