From 14db1dfd88b987c9119f59f75f1f27b8e7c49602 Mon Sep 17 00:00:00 2001 From: Sergey Berezin Date: Wed, 22 Mar 2017 01:05:12 +0000 Subject: [PATCH] Revert "define builder_cache base path" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit e718958ca03fc0766459fecf7820a300b206d7be. Reason for revert: Suspected to have caused an outage http://o/370111 It seems to have shifted the current dir to a new place, created another checkout and some bots with small disk space ran out of disk. Original change's description: > define builder_cache base path > > chromium_tests recipe module currently checks if builder_cache base path > is defined. If it is not, it let's the caller to decide where to put > the cache. All the callers choose start_dir. > https://cs.chromium.org/search/?q=get_checkout_dir&type=cs > > In LUCI we want to use [CACHE]/builder as builder cache. To do that we > want to update chromium_tests recipe module to use [CACHE]/builder if > builder_cache is not defined. > > Define builder_cache in buildbot to point to start dir, so that in LUCI > it is not defined and thus [CACHE]/builder is used. > > R=​iannucci@chromium.org > BUG=660481 > > Change-Id: I9018da5c43a5396add6a26ad2c12b1755fbe6307 > Reviewed-on: https://chromium-review.googlesource.com/457439 > Reviewed-by: Ryan Tseng > Commit-Queue: Nodir Turakulov > TBR=iannucci@chromium.org,hinoka@chromium.org,estaab@chromium.org,nodir@chromium.org,chromium-reviews@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=660481 Change-Id: Ia239ebe12a5bea1987c2ee23e543460efe753c81 Reviewed-on: https://chromium-review.googlesource.com/457778 Reviewed-by: Sergey Berezin Commit-Queue: Sergey Berezin --- recipe_modules/infra_paths/path_config.py | 1 - 1 file changed, 1 deletion(-) diff --git a/recipe_modules/infra_paths/path_config.py b/recipe_modules/infra_paths/path_config.py index 55199ef818..9d419451dc 100644 --- a/recipe_modules/infra_paths/path_config.py +++ b/recipe_modules/infra_paths/path_config.py @@ -16,7 +16,6 @@ def infra_buildbot(c): c.base_paths['root'] = c.START_DIR[:-4] c.base_paths['cache'] = c.base_paths['root'] + ( 'build', 'slave', 'cache') - c.base_paths['builder_cache'] = c.START_DIR c.base_paths['git_cache'] = c.base_paths['root'] + ( 'build', 'slave', 'cache_dir') c.base_paths['goma_cache'] = c.base_paths['root'] + (