From 0f8a944d84f2162f2139c1bed0b09566cf8798ba Mon Sep 17 00:00:00 2001 From: "dbeam@chromium.org" Date: Tue, 10 Jul 2012 14:50:20 +0000 Subject: [PATCH] [depot_tools] Allow gclient runhooks to work offline w/safesync_url. R=maruel@chromium.org BUG=None (AFAIK) TEST=Turn off networking, run gclient runhooks. Review URL: https://chromiumcodereview.appspot.com/10750007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@145878 0039d316-1c4b-4281-b951-d872f2087c98 --- gclient.py | 2 +- tests/trychange_unittest.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/gclient.py b/gclient.py index 52dfb6881..30bad034d 100644 --- a/gclient.py +++ b/gclient.py @@ -1007,7 +1007,7 @@ solutions = [ revision_overrides = {} # It's unnecessary to check for revision overrides for 'recurse'. # Save a few seconds by not calling _EnforceRevisions() in that case. - if command is not 'recurse': + if command not in ('diff', 'recurse', 'runhooks', 'status'): revision_overrides = self._EnforceRevisions() pm = None # Disable progress for non-tty stdout. diff --git a/tests/trychange_unittest.py b/tests/trychange_unittest.py index 6467b6a7d..3e8887e0b 100755 --- a/tests/trychange_unittest.py +++ b/tests/trychange_unittest.py @@ -108,6 +108,7 @@ class SVNUnittest(TryChangeTestsBase): self.compareMembers(trychange.SVN, members) def testBasic(self): + # pylint: disable=E1103 trychange.os.path.abspath(self.fake_root).AndReturn(self.fake_root) trychange.scm.SVN.GetCheckoutRoot(self.fake_root).AndReturn(self.fake_root) trychange.scm.SVN.GenerateDiff(['foo.txt', 'bar.txt'],