From 0f402641d07b62c39f271bd764388c664d0e5ad2 Mon Sep 17 00:00:00 2001 From: Andrii Shyshkalov Date: Tue, 4 May 2021 21:04:20 +0000 Subject: [PATCH] [auth] log errors from luci-auth token invocation. Motivating example -- seemingly empty output in this build: https://luci-milo.appspot.com/ui/p/devtools-internal/builders/ci/Auto-roll%20-%20frontend/587/overview R=vadimsh Change-Id: I12f1acb1b4852f57057684b26fb153ab74e2da39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2871721 Reviewed-by: Vadim Shtayura Reviewed-by: Dirk Pranke Commit-Queue: Andrii Shyshkalov Auto-Submit: Andrii Shyshkalov --- auth.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/auth.py b/auth.py index 204cfb7d4..b01664b56 100644 --- a/auth.py +++ b/auth.py @@ -159,5 +159,7 @@ class Authenticator(object): return AccessToken( token_info['token'], datetime.datetime.utcfromtimestamp(token_info['expiry'])) - except subprocess2.CalledProcessError: + except subprocess2.CalledProcessError as e: + # subprocess2.CalledProcessError.__str__ nicely formats stdout/stderr. + logging.error('luci-auth token failed: %s', e) return None