From 0b12346bf3ac1c324c9a1b794988686b4ed0ea01 Mon Sep 17 00:00:00 2001 From: Josip Sokcevic Date: Tue, 8 Jun 2021 20:41:32 +0000 Subject: [PATCH] [py3] Return list of strings in GitChange.AllFiles Currently, GitChange.AllFiles returns a list of byte[]. This is inconsistent with py2 and may cause issues when byte[] is used when string is expected. Change-Id: I3e73bc5f71aa787f55357b8139cdeeabee056047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2946934 Commit-Queue: Josip Sokcevic Commit-Queue: Edward Lesmes Auto-Submit: Josip Sokcevic Reviewed-by: Edward Lesmes --- presubmit_support.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/presubmit_support.py b/presubmit_support.py index 11102117e..023243fd1 100755 --- a/presubmit_support.py +++ b/presubmit_support.py @@ -1309,7 +1309,7 @@ class GitChange(Change): root = root or self.RepositoryRoot() return subprocess.check_output( ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'], - cwd=root).splitlines() + cwd=root).decode('utf-8', 'ignore').splitlines() def ListRelevantPresubmitFiles(files, root):