From 0af9b70a0228e92ef9c403ab33287b6e41827598 Mon Sep 17 00:00:00 2001
From: "evan@chromium.org"
 <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Sat, 11 Feb 2012 00:42:16 +0000
Subject: [PATCH] git-cl: split GetRietveldServer from GetIssue

Should be no functional change.
Necessary for a follow-up change I'm making.

Review URL: http://codereview.chromium.org/9385017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@121590 0039d316-1c4b-4281-b951-d872f2087c98
---
 git_cl.py            | 17 ++++++++++-------
 tests/git_cl_test.py |  2 +-
 2 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/git_cl.py b/git_cl.py
index 268703034..56d86f2f0 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -397,17 +397,20 @@ or verify this branch is set up to track another (via the --track argument to
       issue = RunGit(['config', self._IssueSetting()], error_ok=True).strip()
       if issue:
         self.issue = issue
-        self.rietveld_server = gclient_utils.UpgradeToHttps(RunGit(
-            ['config', self._RietveldServer()], error_ok=True).strip())
       else:
         self.issue = None
-      if not self.rietveld_server:
-        self.rietveld_server = settings.GetDefaultServerUrl()
       self.has_issue = True
     return self.issue
 
   def GetRietveldServer(self):
-    self.GetIssue()
+    if not self.rietveld_server:
+      # If we're on a branch then get the server potentially associated
+      # with that branch.
+      if self.GetIssue():
+        self.rietveld_server = gclient_utils.UpgradeToHttps(RunGit(
+            ['config', self._RietveldServer()], error_ok=True).strip())
+      if not self.rietveld_server:
+        self.rietveld_server = settings.GetDefaultServerUrl()
     return self.rietveld_server
 
   def GetIssueURL(self):
@@ -564,8 +567,8 @@ or verify this branch is set up to track another (via the --track argument to
     """Returns an upload.RpcServer() to access this review's rietveld instance.
     """
     if not self._rpc_server:
-      self.GetIssue()
-      self._rpc_server = rietveld.Rietveld(self.rietveld_server, None, None)
+      self._rpc_server = rietveld.Rietveld(self.GetRietveldServer(),
+                                           None, None)
     return self._rpc_server
 
   def _IssueSetting(self):
diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index 56df006a8..2e50be271 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -155,9 +155,9 @@ class TestGitCl(TestCase):
          '.'],),
         'M\tPRESUBMIT.py'),
       ((['git', 'config', 'branch.working.rietveldissue'],), '12345'),
+      ((['git', 'config', 'branch.working.rietveldpatchset'],), '31137'),
       ((['git', 'config', 'branch.working.rietveldserver'],),
          'codereview.example.com'),
-      ((['git', 'config', 'branch.working.rietveldpatchset'],), '31137'),
       ((['git', 'config', 'user.email'],), 'author@example.com'),
       ((['git', 'config', 'rietveld.tree-status-url'],), ''),
   ]