From 072d94b68f5a5c5b3dd10d2ffdb987e518ff218c Mon Sep 17 00:00:00 2001 From: "maruel@chromium.org" Date: Thu, 20 Sep 2012 19:20:08 +0000 Subject: [PATCH] Do not enforce HEAD when a revision is not specified. This brings back git cl try to try at LKGR instead of HEAD, which is coherent with git-try and gcl try. R=rogerta@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/10963013 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@157810 0039d316-1c4b-4281-b951-d872f2087c98 --- git_cl.py | 4 ++++ rietveld.py | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/git_cl.py b/git_cl.py index 29ee421ac..f884eaa6c 100755 --- a/git_cl.py +++ b/git_cl.py @@ -1598,6 +1598,10 @@ def CMDtry(parser, args): cl.RpcServer().trigger_try_jobs( cl.GetIssue(), patchset, options.name, options.clobber, options.revision, builders_and_tests) + print('Tried jobs on:') + length = max(len(builder) for builder in builders_and_tests) + for builder in sorted(builders_and_tests): + print ' %*s: %s' % (length, builder, ','.join(builders_and_tests[builder])) return 0 diff --git a/rietveld.py b/rietveld.py index 94f7c6f52..e0bd7a54a 100644 --- a/rietveld.py +++ b/rietveld.py @@ -315,10 +315,11 @@ class Rietveld(object): params = [ ('reason', reason), ('clobber', 'True' if clobber else 'False'), - ('revision', revision if revision else 'HEAD'), ('builders', json.dumps(builders_and_tests)), ('xsrf_token', self.xsrf_token()), ] + if revision: + params.append(('revision', revision)) return self.post('/%d/try/%d' % (issue, patchset), params) def get_pending_try_jobs(self, cursor=None, limit=100):