Remove 150% hard line length limit for long URLs.

BUG=

Review URL: https://codereview.chromium.org/1033363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294600 0039d316-1c4b-4281-b951-d872f2087c98

presubmit_canned_checks.py

@@ -368,12 +368,13 @@ def CheckLongLines(input_api, output_api, maxlen, source_file_filter=None):
     if line_len <= file_maxlen:
       return True
 
-    if line_len > extra_maxlen:
+    # Allow long URLs of any length.
-      return False
-
     if any((url in line) for url in ('file://', 'http://', 'https://')):
       return True
 
+    if line_len > extra_maxlen:
+      return False
+
     if 'url(' in line and file_extension == 'css':
       return True
 

tests/presubmit_unittest.py

@@ -2205,20 +2205,20 @@ class CannedChecksUnittest(PresubmitTestsBase):
     check = lambda x, y, z: presubmit_canned_checks.CheckLongLines(x, y, 10, z)
     self.ContentTest(
         check,
-        ' http:// 0 23 5',
-        None,
         ' http:// 0 23 56',
         None,
+        ' foob:// 0 23 56',
+        None,
         presubmit.OutputApi.PresubmitPromptWarning)
 
   def testCannedCheckLongLinesFile(self):
     check = lambda x, y, z: presubmit_canned_checks.CheckLongLines(x, y, 10, z)
     self.ContentTest(
         check,
-        ' file:// 0 23 5',
-        None,
         ' file:// 0 23 56',
         None,
+        ' foob:// 0 23 56',
+        None,
         presubmit.OutputApi.PresubmitPromptWarning)
 
   def testCannedCheckLongLinesCssUrl(self):