aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'ead9b43bd5'
${ noResults }
depot_tools/recipes/recipe_modules/gerrit/examples/full.expected/basic.json

733 lines
24 KiB
JSON
Raw Normal View History Unescape Escape

Create recipe_modules/gerrit to interact with gerrit REST API BUG= R=mmoss,agable Change-Id: I6410c28280ed05cf384a3da93e6b154c6081e039 Reviewed-on: https://chromium-review.googlesource.com/427375 Reviewed-by: Michael Moss <mmoss@chromium.org>
9 years ago
[
{
"cmd": [
recipes: use vpython3 in gerrit recipe modules This is to prevent failure like https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1057655/overview Bug: 1327534 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I922dddbd23eae0a02a95e020722b5edd1186ef77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3771540 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
3 years ago
"vpython3",
[recipes] Manual roll. Update "import DEPS" syntax and package_repo_resource. recipe_engine: https://crrev.com/a42dce4e0b0db8bd6b7688030e723197919306db [engine] Rewrite/simplify loading infrastructure. (iannucci@chromium.org) R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org Recipe-Manual-Change: skia Recipe-Manual-Change: skiabuildbot Recipe-Manual-Change: build Recipe-Manual-Change: build_limited_scripts_slave Recipe-Manual-Change: infra Recipe-Manual-Change: release_scripts Bug: 914992 Change-Id: Ie3a3be9124e1ca4abd5e79af2f8c946b3ce906ff Reviewed-on: https://chromium-review.googlesource.com/c/1464761 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
7 years ago
"RECIPE_REPO[depot_tools]/gerrit_client.py",
Create recipe_modules/gerrit to interact with gerrit REST API BUG= R=mmoss,agable Change-Id: I6410c28280ed05cf384a3da93e6b154c6081e039 Reviewed-on: https://chromium-review.googlesource.com/427375 Reviewed-by: Michael Moss <mmoss@chromium.org>
9 years ago
"branch",
"--host",
Improve gerrit recipe_module example The /a suffix in the hots URL is not necessary as the gerrit_util adds it by default to authenticate. Having it hard-coded in the example can be misleading. Bug: 685318 Change-Id: I333cd8b2aa9020aadfd186f2e18fbff0aa917681 Reviewed-on: https://chromium-review.googlesource.com/564611 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
8 years ago
"https://chromium-review.googlesource.com",
Create recipe_modules/gerrit to interact with gerrit REST API BUG= R=mmoss,agable Change-Id: I6410c28280ed05cf384a3da93e6b154c6081e039 Reviewed-on: https://chromium-review.googlesource.com/427375 Reviewed-by: Michael Moss <mmoss@chromium.org>
9 years ago
"--project",
"v8/v8",
"--branch",
"test",
"--commit",
"67ebf73496383c6777035e374d2d664009e2aa5c",
"--json_file",
"/path/to/tmp/json"
],
"env": {
[recipes] Manual roll. Update "import DEPS" syntax and package_repo_resource. recipe_engine: https://crrev.com/a42dce4e0b0db8bd6b7688030e723197919306db [engine] Rewrite/simplify loading infrastructure. (iannucci@chromium.org) R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org Recipe-Manual-Change: skia Recipe-Manual-Change: skiabuildbot Recipe-Manual-Change: build Recipe-Manual-Change: build_limited_scripts_slave Recipe-Manual-Change: infra Recipe-Manual-Change: release_scripts Bug: 914992 Change-Id: Ie3a3be9124e1ca4abd5e79af2f8c946b3ce906ff Reviewed-on: https://chromium-review.googlesource.com/c/1464761 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
7 years ago
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
Create recipe_modules/gerrit to interact with gerrit REST API BUG= R=mmoss,agable Change-Id: I6410c28280ed05cf384a3da93e6b154c6081e039 Reviewed-on: https://chromium-review.googlesource.com/427375 Reviewed-by: Michael Moss <mmoss@chromium.org>
9 years ago
},
Roll recipe dependencies (nontrivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM as normal. The recipe roller will *NOT* CQ the change itself, so you must CQ the change manually. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/05a33f9dcf2289bbaf233fcae1e2fb508d95f528 Record infra_step in recipe expectations (phajdan.jr@chromium.org) R=phajdan.jr@chromium.org Change-Id: Ic1202d82b7bb4376976c1b4989cbbd7d26d7c531 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/454341 Commit-Queue: <recipe-roller@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
9 years ago
"infra_step": true,
Add some differentiating details to gerrit step names. R=phajdan.jr@chromium.org Recipe-Manual-Change: release_scripts Recipe-Nontrivial-Roll: release_scripts Change-Id: I4c3ca01bad7e5158565a8abc8d7fc5b4b77b0d4f Reviewed-on: https://chromium-review.googlesource.com/666977 Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
8 years ago
"name": "gerrit create_gerrit_branch (v8/v8 test)",
Create recipe_modules/gerrit to interact with gerrit REST API BUG= R=mmoss,agable Change-Id: I6410c28280ed05cf384a3da93e6b154c6081e039 Reviewed-on: https://chromium-review.googlesource.com/427375 Reviewed-by: Michael Moss <mmoss@chromium.org>
9 years ago
"~followup_annotations": [
"@@@STEP_LOG_LINE@json.output@{@@@",
"@@@STEP_LOG_LINE@json.output@ \"can_delete\": true, @@@",
"@@@STEP_LOG_LINE@json.output@ \"ref\": \"refs/heads/test\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"revision\": \"76016386a0d8ecc7b6be212424978bb45959d668\"@@@",
"@@@STEP_LOG_LINE@json.output@}@@@",
"@@@STEP_LOG_END@json.output@@@"
]
},
{
"cmd": [
recipes: use vpython3 in gerrit recipe modules This is to prevent failure like https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1057655/overview Bug: 1327534 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I922dddbd23eae0a02a95e020722b5edd1186ef77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3771540 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
3 years ago
"vpython3",
[recipes] Manual roll. Update "import DEPS" syntax and package_repo_resource. recipe_engine: https://crrev.com/a42dce4e0b0db8bd6b7688030e723197919306db [engine] Rewrite/simplify loading infrastructure. (iannucci@chromium.org) R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org Recipe-Manual-Change: skia Recipe-Manual-Change: skiabuildbot Recipe-Manual-Change: build Recipe-Manual-Change: build_limited_scripts_slave Recipe-Manual-Change: infra Recipe-Manual-Change: release_scripts Bug: 914992 Change-Id: Ie3a3be9124e1ca4abd5e79af2f8c946b3ce906ff Reviewed-on: https://chromium-review.googlesource.com/c/1464761 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
7 years ago
"RECIPE_REPO[depot_tools]/gerrit_client.py",
Create recipe_modules/gerrit to interact with gerrit REST API BUG= R=mmoss,agable Change-Id: I6410c28280ed05cf384a3da93e6b154c6081e039 Reviewed-on: https://chromium-review.googlesource.com/427375 Reviewed-by: Michael Moss <mmoss@chromium.org>
9 years ago
"branchinfo",
"--host",
Improve gerrit recipe_module example The /a suffix in the hots URL is not necessary as the gerrit_util adds it by default to authenticate. Having it hard-coded in the example can be misleading. Bug: 685318 Change-Id: I333cd8b2aa9020aadfd186f2e18fbff0aa917681 Reviewed-on: https://chromium-review.googlesource.com/564611 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
8 years ago
"https://chromium-review.googlesource.com",
Create recipe_modules/gerrit to interact with gerrit REST API BUG= R=mmoss,agable Change-Id: I6410c28280ed05cf384a3da93e6b154c6081e039 Reviewed-on: https://chromium-review.googlesource.com/427375 Reviewed-by: Michael Moss <mmoss@chromium.org>
9 years ago
"--project",
"v8/v8",
"--branch",
Use main as default branch in all recipes Recipe-Manual-Change: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I89008bc07b1c3de13d9c6dd64e723fe6dc8d01d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3015262 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Gavin Mak <gavinmak@google.com> Reviewed-by: Anthony Polito <apolito@google.com>
4 years ago
"main",
Create recipe_modules/gerrit to interact with gerrit REST API BUG= R=mmoss,agable Change-Id: I6410c28280ed05cf384a3da93e6b154c6081e039 Reviewed-on: https://chromium-review.googlesource.com/427375 Reviewed-by: Michael Moss <mmoss@chromium.org>
9 years ago
"--json_file",
"/path/to/tmp/json"
],
"env": {
[recipes] Manual roll. Update "import DEPS" syntax and package_repo_resource. recipe_engine: https://crrev.com/a42dce4e0b0db8bd6b7688030e723197919306db [engine] Rewrite/simplify loading infrastructure. (iannucci@chromium.org) R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org Recipe-Manual-Change: skia Recipe-Manual-Change: skiabuildbot Recipe-Manual-Change: build Recipe-Manual-Change: build_limited_scripts_slave Recipe-Manual-Change: infra Recipe-Manual-Change: release_scripts Bug: 914992 Change-Id: Ie3a3be9124e1ca4abd5e79af2f8c946b3ce906ff Reviewed-on: https://chromium-review.googlesource.com/c/1464761 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
7 years ago
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
Create recipe_modules/gerrit to interact with gerrit REST API BUG= R=mmoss,agable Change-Id: I6410c28280ed05cf384a3da93e6b154c6081e039 Reviewed-on: https://chromium-review.googlesource.com/427375 Reviewed-by: Michael Moss <mmoss@chromium.org>
9 years ago
},
Roll recipe dependencies (nontrivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM as normal. The recipe roller will *NOT* CQ the change itself, so you must CQ the change manually. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/05a33f9dcf2289bbaf233fcae1e2fb508d95f528 Record infra_step in recipe expectations (phajdan.jr@chromium.org) R=phajdan.jr@chromium.org Change-Id: Ic1202d82b7bb4376976c1b4989cbbd7d26d7c531 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/454341 Commit-Queue: <recipe-roller@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
9 years ago
"infra_step": true,
Use main as default branch in all recipes Recipe-Manual-Change: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I89008bc07b1c3de13d9c6dd64e723fe6dc8d01d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3015262 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Gavin Mak <gavinmak@google.com> Reviewed-by: Anthony Polito <apolito@google.com>
4 years ago
"name": "gerrit get_gerrit_branch (v8/v8 main)",
Create recipe_modules/gerrit to interact with gerrit REST API BUG= R=mmoss,agable Change-Id: I6410c28280ed05cf384a3da93e6b154c6081e039 Reviewed-on: https://chromium-review.googlesource.com/427375 Reviewed-by: Michael Moss <mmoss@chromium.org>
9 years ago
"~followup_annotations": [
"@@@STEP_LOG_LINE@json.output@{@@@",
Replace non-inclusive terms Bug: 1118410, 1118413, 1118422, 1118424, 1118426 Bug: 1118428, 1118430, 1118434, 1118438, 1118442 Bug: 1118453, 1118454 Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: build Change-Id: I43e6305f8c3136774f01b57f12bb442bcb863371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2551388 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
5 years ago
"@@@STEP_LOG_LINE@json.output@ \"ref\": \"refs/heads/main\", @@@",
Create recipe_modules/gerrit to interact with gerrit REST API BUG= R=mmoss,agable Change-Id: I6410c28280ed05cf384a3da93e6b154c6081e039 Reviewed-on: https://chromium-review.googlesource.com/427375 Reviewed-by: Michael Moss <mmoss@chromium.org>
9 years ago
"@@@STEP_LOG_LINE@json.output@ \"revision\": \"67ebf73496383c6777035e374d2d664009e2aa5c\"@@@",
"@@@STEP_LOG_LINE@json.output@}@@@",
"@@@STEP_LOG_END@json.output@@@"
]
},
Add 'create tag' support to gerrit_client and gerrit recipe_module. BUG=1052179 R=dpranke@google.com, linxinan@chromium.org Change-Id: I6e220b70e63d990e9257d9fe4d107de7dbd2eb81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3232849 Auto-Submit: Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by: Xinan Lin <linxinan@chromium.org> Reviewed-by: Dirk Pranke <dpranke@google.com>
4 years ago
{
"cmd": [
recipes: use vpython3 in gerrit recipe modules This is to prevent failure like https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1057655/overview Bug: 1327534 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I922dddbd23eae0a02a95e020722b5edd1186ef77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3771540 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
3 years ago
"vpython3",
Add 'create tag' support to gerrit_client and gerrit recipe_module. BUG=1052179 R=dpranke@google.com, linxinan@chromium.org Change-Id: I6e220b70e63d990e9257d9fe4d107de7dbd2eb81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3232849 Auto-Submit: Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by: Xinan Lin <linxinan@chromium.org> Reviewed-by: Dirk Pranke <dpranke@google.com>
4 years ago
"RECIPE_REPO[depot_tools]/gerrit_client.py",
"tag",
"--host",
"https://chromium-review.googlesource.com",
"--project",
"v8/v8",
"--tag",
"1.0",
"--commit",
"67ebf73496383c6777035e374d2d664009e2aa5c",
"--json_file",
"/path/to/tmp/json"
],
"env": {
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "gerrit create_gerrit_tag (v8/v8 1.0)",
"~followup_annotations": [
Add ability to generically call most Gerrit APIs. This will make it easier to call new or uncommon Gerrit APIs, without needing to add dedicated methods for each one. This also makes it easier to debug API calls by exposing the raw response data, which is often processed or filtered in the existing wrapper methods. BUG=1052179 R=linxinan@chromium.org Change-Id: I0b594a9fdaabae4b0ebb379dc5473f4d6de67a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3235714 Auto-Submit: Michael Moss <mmoss@chromium.org> Reviewed-by: Dirk Pranke <dpranke@google.com> Reviewed-by: Xinan Lin <linxinan@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com>
4 years ago
"@@@STEP_LOG_LINE@json.output@{@@@",
"@@@STEP_LOG_LINE@json.output@ \"can_delete\": true, @@@",
"@@@STEP_LOG_LINE@json.output@ \"ref\": \"refs/tags/1.0\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"revision\": \"67ebf73496383c6777035e374d2d664009e2aa5c\"@@@",
"@@@STEP_LOG_LINE@json.output@}@@@",
"@@@STEP_LOG_END@json.output@@@"
]
},
{
"cmd": [
recipes: use vpython3 in gerrit recipe modules This is to prevent failure like https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1057655/overview Bug: 1327534 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I922dddbd23eae0a02a95e020722b5edd1186ef77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3771540 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
3 years ago
"vpython3",
Add ability to generically call most Gerrit APIs. This will make it easier to call new or uncommon Gerrit APIs, without needing to add dedicated methods for each one. This also makes it easier to debug API calls by exposing the raw response data, which is often processed or filtered in the existing wrapper methods. BUG=1052179 R=linxinan@chromium.org Change-Id: I0b594a9fdaabae4b0ebb379dc5473f4d6de67a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3235714 Auto-Submit: Michael Moss <mmoss@chromium.org> Reviewed-by: Dirk Pranke <dpranke@google.com> Reviewed-by: Xinan Lin <linxinan@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com>
4 years ago
"RECIPE_REPO[depot_tools]/gerrit_client.py",
"rawapi",
"--host",
"https://chromium-review.googlesource.com",
"--path",
"/projects/v8/v8/tags/1.0",
"--json_file",
"/path/to/tmp/json",
"--method",
"PUT",
"--body",
"{\"revision\": \"67ebf73496383c6777035e374d2d664009e2aa5c\"}",
"--accept_status",
"201"
],
"env": {
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "gerrit raw_create_tag",
"~followup_annotations": [
Add 'create tag' support to gerrit_client and gerrit recipe_module. BUG=1052179 R=dpranke@google.com, linxinan@chromium.org Change-Id: I6e220b70e63d990e9257d9fe4d107de7dbd2eb81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3232849 Auto-Submit: Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by: Xinan Lin <linxinan@chromium.org> Reviewed-by: Dirk Pranke <dpranke@google.com>
4 years ago
"@@@STEP_LOG_LINE@json.output@{@@@",
"@@@STEP_LOG_LINE@json.output@ \"can_delete\": true, @@@",
"@@@STEP_LOG_LINE@json.output@ \"ref\": \"refs/tags/1.0\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"revision\": \"67ebf73496383c6777035e374d2d664009e2aa5c\"@@@",
"@@@STEP_LOG_LINE@json.output@}@@@",
"@@@STEP_LOG_END@json.output@@@"
]
},
Add move change to Gerrit recipes Will be used by a LUCI cron to move Gerrit changes for repos that are in transition state #1 and #2. R=ehmaldonado@chromium.org Change-Id: Id7383ef677aa1cc90102c9a2aadbcc17712e150d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2522559 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
5 years ago
{
"cmd": [
recipes: use vpython3 in gerrit recipe modules This is to prevent failure like https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1057655/overview Bug: 1327534 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I922dddbd23eae0a02a95e020722b5edd1186ef77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3771540 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
3 years ago
"vpython3",
Add move change to Gerrit recipes Will be used by a LUCI cron to move Gerrit changes for repos that are in transition state #1 and #2. R=ehmaldonado@chromium.org Change-Id: Id7383ef677aa1cc90102c9a2aadbcc17712e150d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2522559 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
5 years ago
"RECIPE_REPO[depot_tools]/gerrit_client.py",
"movechanges",
"--host",
"https://chromium-review.googlesource.com",
"-p",
"project=v8/v8",
"-p",
"branch=master",
"-p",
"status=open",
"--destination_branch",
"main",
"--json_file",
"/path/to/tmp/json"
],
"env": {
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "gerrit move changes",
"~followup_annotations": [
"@@@STEP_LOG_LINE@json.output@[@@@",
"@@@STEP_LOG_LINE@json.output@ {@@@",
"@@@STEP_LOG_LINE@json.output@ \"_number\": \"91827\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"branch\": \"main\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"change_id\": \"Ideadbeef\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"created\": \"2017-01-30 13:11:20.000000000\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"has_review_started\": false, @@@",
Add step test data for update_files() in Gerrit module Thus downstream recipes could run "train" without explicit mock data everywhere. BUG=1293270 TEST=train Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Change-Id: I09f6a27097f400dabd990f6ef61e301a75a39691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3502768 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Xinan Lin <linxinan@chromium.org>
4 years ago
"@@@STEP_LOG_LINE@json.output@ \"id\": \"fully~qualified~changeid\", @@@",
Add move change to Gerrit recipes Will be used by a LUCI cron to move Gerrit changes for repos that are in transition state #1 and #2. R=ehmaldonado@chromium.org Change-Id: Id7383ef677aa1cc90102c9a2aadbcc17712e150d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2522559 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
5 years ago
"@@@STEP_LOG_LINE@json.output@ \"project\": \"chromium/src\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"revisions\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"184ebe53805e102605d11f6b143486d15c23a09c\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"_number\": \"1\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"commit\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"message\": \"Change commit message\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@ }, @@@",
"@@@STEP_LOG_LINE@json.output@ \"status\": \"NEW\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"subject\": \"Change title\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@]@@@",
"@@@STEP_LOG_END@json.output@@@"
]
},
Add new API to update files by gerrit module The new API here could support users to update files to remote repo without loading the source code to the bot. BUG=1207955 TEST=train Change-Id: I2970171bf5b58db0db41bab5a433fc6721b7b2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3042407 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
4 years ago
{
"cmd": [
recipes: use vpython3 in gerrit recipe modules This is to prevent failure like https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1057655/overview Bug: 1327534 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I922dddbd23eae0a02a95e020722b5edd1186ef77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3771540 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
3 years ago
"vpython3",
Add new API to update files by gerrit module The new API here could support users to update files to remote repo without loading the source code to the bot. BUG=1207955 TEST=train Change-Id: I2970171bf5b58db0db41bab5a433fc6721b7b2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3042407 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
4 years ago
"RECIPE_REPO[depot_tools]/gerrit_client.py",
"createchange",
"--host",
"https://chromium-review.googlesource.com",
"--project",
"v8/v8",
"--branch",
"main",
"--subject",
"Dummy CL.",
"--json_file",
Add params to update_files method params in the form 'key=value' is required by gerrit_client tool, although may not be used by the backend. BUG=1207955 TEST=e2e Recipe-Nontrivial-Roll: chrome_release Change-Id: I1181868060af921f87efe55ea9f60fa37ae8b215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3068823 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
4 years ago
"/path/to/tmp/json",
"-p",
Add cc_list to update_files method User could attach CC addresses to the gerrit change created. BUG=1294382 TEST=train Change-Id: I236658d80f41b27bf007bb344934ce835cd7b5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3440862 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Xinan Lin <linxinan@chromium.org>
4 years ago
"status=NEW",
"--cc",
"foo@example.com"
Add new API to update files by gerrit module The new API here could support users to update files to remote repo without loading the source code to the bot. BUG=1207955 TEST=train Change-Id: I2970171bf5b58db0db41bab5a433fc6721b7b2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3042407 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
4 years ago
],
"env": {
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "gerrit create change at (v8/v8 main)",
"~followup_annotations": [
"@@@STEP_LOG_LINE@json.output@{@@@",
"@@@STEP_LOG_LINE@json.output@ \"_number\": \"91827\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"branch\": \"main\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"change_id\": \"Ideadbeef\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"created\": \"2017-01-30 13:11:20.000000000\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"has_review_started\": false, @@@",
Add step test data for update_files() in Gerrit module Thus downstream recipes could run "train" without explicit mock data everywhere. BUG=1293270 TEST=train Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Change-Id: I09f6a27097f400dabd990f6ef61e301a75a39691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3502768 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Xinan Lin <linxinan@chromium.org>
4 years ago
"@@@STEP_LOG_LINE@json.output@ \"id\": \"fully~qualified~changeid\", @@@",
Add new API to update files by gerrit module The new API here could support users to update files to remote repo without loading the source code to the bot. BUG=1207955 TEST=train Change-Id: I2970171bf5b58db0db41bab5a433fc6721b7b2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3042407 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
4 years ago
"@@@STEP_LOG_LINE@json.output@ \"project\": \"chromium/src\", @@@",
Return changeinfo from update_files method Users may need more info from a created/submitted change, e.g. revision hash, change status(submitted or not) etc. BUG=1236658 TEST=train Recipe-Nontrivial-Roll: chrome_release Change-Id: I1db57e5c6a4e58ea320526ef5f5cbb83e1b0bb60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3102579 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@google.com> Reviewed-by: Michael Moss <mmoss@chromium.org>
4 years ago
"@@@STEP_LOG_LINE@json.output@ \"revisions\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"184ebe53805e102605d11f6b143486d15c23a09c\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"_number\": \"1\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"commit\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"message\": \"Change commit message\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@ }, @@@",
Add new API to update files by gerrit module The new API here could support users to update files to remote repo without loading the source code to the bot. BUG=1207955 TEST=train Change-Id: I2970171bf5b58db0db41bab5a433fc6721b7b2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3042407 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
4 years ago
"@@@STEP_LOG_LINE@json.output@ \"status\": \"NEW\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"subject\": \"Change title\"@@@",
"@@@STEP_LOG_LINE@json.output@}@@@",
"@@@STEP_LOG_END@json.output@@@",
"@@@STEP_LINK@change 91827@https://chromium-review.googlesource.com/#/q/91827@@@"
]
},
{
"cmd": [],
"name": "update contents in CL 91827"
},
{
"cmd": [
Roll recipe dependencies (nontrivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8813625169557805905 Please review the expectation changes, and LGTM+CQ. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/a58dd35fb76ad00a77bd44508f1b6aaafdbb1a2b a58dd35 (tikuta@chromium.org) file: use vpython3 to run scripts in resources dir More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I116fa1e5faafade1c85a4cca7077b926af788a8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3657049 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
3 years ago
"vpython3",
Add new API to update files by gerrit module The new API here could support users to update files to remote repo without loading the source code to the bot. BUG=1207955 TEST=train Change-Id: I2970171bf5b58db0db41bab5a433fc6721b7b2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3042407 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
4 years ago
"-u",
"RECIPE_MODULE[recipe_engine::file]/resources/fileutil.py",
"--json-output",
"/path/to/tmp/json",
"copy",
"99.99.99.99",
"[CLEANUP]/tmp_tmp_1"
],
"infra_step": true,
"name": "update contents in CL 91827.store the new content for chrome/VERSION",
"~followup_annotations": [
Roll recipe dependencies (nontrivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8829745138191541841 Please review the expectation changes, and LGTM+CQ. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/206cd301ad30ada2437dda4ad370906f4c1d8156 206cd30 (gbeaty@chromium.org) Remove the log from write_raw. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=dpranke@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ifb9fe37d3d17fdb9b13ddab317c3357bf4e014b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3298693 Auto-Submit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Garrett Beaty <gbeaty@google.com> Reviewed-by: Garrett Beaty <gbeaty@google.com>
4 years ago
"@@@STEP_NEST_LEVEL@1@@@"
Add new API to update files by gerrit module The new API here could support users to update files to remote repo without loading the source code to the bot. BUG=1207955 TEST=train Change-Id: I2970171bf5b58db0db41bab5a433fc6721b7b2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3042407 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
4 years ago
]
},
{
"cmd": [
recipes: use vpython3 in gerrit recipe modules This is to prevent failure like https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1057655/overview Bug: 1327534 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I922dddbd23eae0a02a95e020722b5edd1186ef77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3771540 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
3 years ago
"vpython3",
Add new API to update files by gerrit module The new API here could support users to update files to remote repo without loading the source code to the bot. BUG=1207955 TEST=train Change-Id: I2970171bf5b58db0db41bab5a433fc6721b7b2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3042407 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
4 years ago
"RECIPE_REPO[depot_tools]/gerrit_client.py",
"changeedit",
"--host",
"https://chromium-review.googlesource.com",
"--change",
"91827",
"--path",
"chrome/VERSION",
"--file",
"[CLEANUP]/tmp_tmp_1"
],
"env": {
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "update contents in CL 91827.gerrit edit file chrome/VERSION",
"~followup_annotations": [
"@@@STEP_NEST_LEVEL@1@@@"
]
},
{
"cmd": [
recipes: use vpython3 in gerrit recipe modules This is to prevent failure like https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1057655/overview Bug: 1327534 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I922dddbd23eae0a02a95e020722b5edd1186ef77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3771540 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
3 years ago
"vpython3",
Add new API to update files by gerrit module The new API here could support users to update files to remote repo without loading the source code to the bot. BUG=1207955 TEST=train Change-Id: I2970171bf5b58db0db41bab5a433fc6721b7b2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3042407 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
4 years ago
"RECIPE_REPO[depot_tools]/gerrit_client.py",
"publishchangeedit",
"--host",
"https://chromium-review.googlesource.com",
"--change",
"91827"
],
"env": {
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "gerrit publish edit"
},
Ensure the new patchset exists in Gerrit before we set bot-commit+1 "Publish Change Edit" is not a synchronized API call on Gerrit. After the call, we need to explicitly check if the new patch exists in Gerrit. Or, we may label +1 on an old patch. BUG=1286212 TEST=train Recipe-Nontrivial-Roll: chrome_release Change-Id: I1443e2b4cf702f7cb4feebb43e34923f11383f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3384422 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Xinan Lin <linxinan@chromium.org>
4 years ago
{
"cmd": [],
"name": "verify the patchset exists on CL 91827"
},
{
"cmd": [
recipes: use vpython3 in gerrit recipe modules This is to prevent failure like https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1057655/overview Bug: 1327534 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I922dddbd23eae0a02a95e020722b5edd1186ef77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3771540 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
3 years ago
"vpython3",
Ensure the new patchset exists in Gerrit before we set bot-commit+1 "Publish Change Edit" is not a synchronized API call on Gerrit. After the call, we need to explicitly check if the new patch exists in Gerrit. Or, we may label +1 on an old patch. BUG=1286212 TEST=train Recipe-Nontrivial-Roll: chrome_release Change-Id: I1443e2b4cf702f7cb4feebb43e34923f11383f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3384422 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Xinan Lin <linxinan@chromium.org>
4 years ago
"RECIPE_REPO[depot_tools]/gerrit_client.py",
"changes",
Add timeouts to the actual http calls in gerrit_util.py When gerrit's availability drops, chrome's builds see an excessive amount of failures, eg: https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359780/overview https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359594/overview https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359564/overview https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359630/overview Seemingly all failures occur in either the `gerrit fetch current CL info` step or the `gerrit changes` step. Both steps have a 60s timeout and shell out to depot_tools' gerrit_client.py. That script essentially makes a single http call to gerrit. That request has no configured timeout. So when gerrit's MIA and the call hangs indefinitely, so too will the step hang. 60s after that, the step timeout is reached, and the entire build crashes with an infra-failure. However, one single retry has been shown to sufficiently work around at least one instance of that failure: https://luci-milo.appspot.com/raw/build/logs.chromium.org/chromium/led/bpastene_google.com/dea9a6eca2543e87ee356cedd9d105cdccd375906f690ce10a959701a8fb51ad/+/build.proto So this incorporates timeouts into the requests made by gerrit_util.py. Each request is given a 10s timeout, which should be enough for most/all gerrit calls. (Both steps have a p90 of less than 1sec.) When a timeout is reached, the script will automatically retry up to 4 times. This also bumps the timeouts of the step calls to gerrit_client.py to 6min since the script can now take up to 5 minutes to fail, ie: the sequence of sleeps is roughly 10s, 20s, 40s, 80s, 160s, which is about 5min. So a 6min timeout should cover all those retries. This also passes in "--verbose" to all step calls to this script, so the logging that prints out the retry + sleep log lines will be visible in build logs. Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Bug: 1432638 Change-Id: I9dc47f4beeda3783ae4f9152bd29ee441ac3e197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4420526 Reviewed-by: Joanna Wang <jojwang@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org>
2 years ago
"--verbose",
Ensure the new patchset exists in Gerrit before we set bot-commit+1 "Publish Change Edit" is not a synchronized API call on Gerrit. After the call, we need to explicitly check if the new patch exists in Gerrit. Or, we may label +1 on an old patch. BUG=1286212 TEST=train Recipe-Nontrivial-Roll: chrome_release Change-Id: I1443e2b4cf702f7cb4feebb43e34923f11383f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3384422 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Xinan Lin <linxinan@chromium.org>
4 years ago
"--host",
"https://chromium-review.googlesource.com",
"--json_file",
"/path/to/tmp/json",
"--limit",
"1",
"-p",
"change=91827",
"-o",
"ALL_REVISIONS",
"-o",
"ALL_COMMITS"
],
"env": {
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "verify the patchset exists on CL 91827.gerrit changes",
"~followup_annotations": [
"@@@STEP_NEST_LEVEL@1@@@",
"@@@STEP_LOG_LINE@json.output@[]@@@",
"@@@STEP_LOG_END@json.output@@@"
]
},
{
"cmd": [],
"name": "verify the patchset exists on CL 91827.waiting before retry",
"~followup_annotations": [
"@@@STEP_NEST_LEVEL@1@@@"
]
},
{
"cmd": [
recipes: use vpython3 in gerrit recipe modules This is to prevent failure like https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1057655/overview Bug: 1327534 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I922dddbd23eae0a02a95e020722b5edd1186ef77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3771540 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
3 years ago
"vpython3",
Ensure the new patchset exists in Gerrit before we set bot-commit+1 "Publish Change Edit" is not a synchronized API call on Gerrit. After the call, we need to explicitly check if the new patch exists in Gerrit. Or, we may label +1 on an old patch. BUG=1286212 TEST=train Recipe-Nontrivial-Roll: chrome_release Change-Id: I1443e2b4cf702f7cb4feebb43e34923f11383f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3384422 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Xinan Lin <linxinan@chromium.org>
4 years ago
"RECIPE_REPO[depot_tools]/gerrit_client.py",
"changes",
Add timeouts to the actual http calls in gerrit_util.py When gerrit's availability drops, chrome's builds see an excessive amount of failures, eg: https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359780/overview https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359594/overview https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359564/overview https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359630/overview Seemingly all failures occur in either the `gerrit fetch current CL info` step or the `gerrit changes` step. Both steps have a 60s timeout and shell out to depot_tools' gerrit_client.py. That script essentially makes a single http call to gerrit. That request has no configured timeout. So when gerrit's MIA and the call hangs indefinitely, so too will the step hang. 60s after that, the step timeout is reached, and the entire build crashes with an infra-failure. However, one single retry has been shown to sufficiently work around at least one instance of that failure: https://luci-milo.appspot.com/raw/build/logs.chromium.org/chromium/led/bpastene_google.com/dea9a6eca2543e87ee356cedd9d105cdccd375906f690ce10a959701a8fb51ad/+/build.proto So this incorporates timeouts into the requests made by gerrit_util.py. Each request is given a 10s timeout, which should be enough for most/all gerrit calls. (Both steps have a p90 of less than 1sec.) When a timeout is reached, the script will automatically retry up to 4 times. This also bumps the timeouts of the step calls to gerrit_client.py to 6min since the script can now take up to 5 minutes to fail, ie: the sequence of sleeps is roughly 10s, 20s, 40s, 80s, 160s, which is about 5min. So a 6min timeout should cover all those retries. This also passes in "--verbose" to all step calls to this script, so the logging that prints out the retry + sleep log lines will be visible in build logs. Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Bug: 1432638 Change-Id: I9dc47f4beeda3783ae4f9152bd29ee441ac3e197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4420526 Reviewed-by: Joanna Wang <jojwang@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org>
2 years ago
"--verbose",
Ensure the new patchset exists in Gerrit before we set bot-commit+1 "Publish Change Edit" is not a synchronized API call on Gerrit. After the call, we need to explicitly check if the new patch exists in Gerrit. Or, we may label +1 on an old patch. BUG=1286212 TEST=train Recipe-Nontrivial-Roll: chrome_release Change-Id: I1443e2b4cf702f7cb4feebb43e34923f11383f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3384422 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Xinan Lin <linxinan@chromium.org>
4 years ago
"--host",
"https://chromium-review.googlesource.com",
"--json_file",
"/path/to/tmp/json",
"--limit",
"1",
"-p",
"change=91827",
"-o",
"ALL_REVISIONS",
"-o",
"ALL_COMMITS"
],
"env": {
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "verify the patchset exists on CL 91827.gerrit changes (2)",
"~followup_annotations": [
"@@@STEP_NEST_LEVEL@1@@@",
"@@@STEP_LOG_LINE@json.output@[@@@",
"@@@STEP_LOG_LINE@json.output@ {@@@",
"@@@STEP_LOG_LINE@json.output@ \"_number\": \"91827\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"branch\": \"main\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"change_id\": \"Ideadbeef\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"created\": \"2017-01-30 13:11:20.000000000\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"has_review_started\": false, @@@",
Add step test data for update_files() in Gerrit module Thus downstream recipes could run "train" without explicit mock data everywhere. BUG=1293270 TEST=train Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Change-Id: I09f6a27097f400dabd990f6ef61e301a75a39691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3502768 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Xinan Lin <linxinan@chromium.org>
4 years ago
"@@@STEP_LOG_LINE@json.output@ \"id\": \"fully~qualified~changeid\", @@@",
Ensure the new patchset exists in Gerrit before we set bot-commit+1 "Publish Change Edit" is not a synchronized API call on Gerrit. After the call, we need to explicitly check if the new patch exists in Gerrit. Or, we may label +1 on an old patch. BUG=1286212 TEST=train Recipe-Nontrivial-Roll: chrome_release Change-Id: I1443e2b4cf702f7cb4feebb43e34923f11383f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3384422 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Xinan Lin <linxinan@chromium.org>
4 years ago
"@@@STEP_LOG_LINE@json.output@ \"project\": \"chromium/src\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"revisions\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"184ebe53805e102605d11f6b143486d15c23a09c\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"_number\": \"2\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"commit\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"message\": \"Change commit message\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@ }, @@@",
"@@@STEP_LOG_LINE@json.output@ \"status\": \"NEW\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"subject\": \"Change title\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@]@@@",
"@@@STEP_LOG_END@json.output@@@"
]
},
Add new API to update files by gerrit module The new API here could support users to update files to remote repo without loading the source code to the bot. BUG=1207955 TEST=train Change-Id: I2970171bf5b58db0db41bab5a433fc6721b7b2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3042407 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
4 years ago
{
"cmd": [
recipes: use vpython3 in gerrit recipe modules This is to prevent failure like https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1057655/overview Bug: 1327534 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I922dddbd23eae0a02a95e020722b5edd1186ef77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3771540 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
3 years ago
"vpython3",
Add new API to update files by gerrit module The new API here could support users to update files to remote repo without loading the source code to the bot. BUG=1207955 TEST=train Change-Id: I2970171bf5b58db0db41bab5a433fc6721b7b2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3042407 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
4 years ago
"RECIPE_REPO[depot_tools]/gerrit_client.py",
"setbotcommit",
"--host",
"https://chromium-review.googlesource.com",
"--change",
"91827"
],
"env": {
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "gerrit set Bot-Commit+1 for change 91827"
},
{
"cmd": [
recipes: use vpython3 in gerrit recipe modules This is to prevent failure like https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1057655/overview Bug: 1327534 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I922dddbd23eae0a02a95e020722b5edd1186ef77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3771540 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
3 years ago
"vpython3",
Add new API to update files by gerrit module The new API here could support users to update files to remote repo without loading the source code to the bot. BUG=1207955 TEST=train Change-Id: I2970171bf5b58db0db41bab5a433fc6721b7b2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3042407 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
4 years ago
"RECIPE_REPO[depot_tools]/gerrit_client.py",
"submitchange",
"--host",
"https://chromium-review.googlesource.com",
"--change",
Return changeinfo from update_files method Users may need more info from a created/submitted change, e.g. revision hash, change status(submitted or not) etc. BUG=1236658 TEST=train Recipe-Nontrivial-Roll: chrome_release Change-Id: I1db57e5c6a4e58ea320526ef5f5cbb83e1b0bb60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3102579 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@google.com> Reviewed-by: Michael Moss <mmoss@chromium.org>
4 years ago
"91827",
"--json_file",
"/path/to/tmp/json"
Add new API to update files by gerrit module The new API here could support users to update files to remote repo without loading the source code to the bot. BUG=1207955 TEST=train Change-Id: I2970171bf5b58db0db41bab5a433fc6721b7b2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3042407 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
4 years ago
],
"env": {
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
Return changeinfo from update_files method Users may need more info from a created/submitted change, e.g. revision hash, change status(submitted or not) etc. BUG=1236658 TEST=train Recipe-Nontrivial-Roll: chrome_release Change-Id: I1db57e5c6a4e58ea320526ef5f5cbb83e1b0bb60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3102579 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@google.com> Reviewed-by: Michael Moss <mmoss@chromium.org>
4 years ago
"name": "gerrit submit change 91827",
"~followup_annotations": [
"@@@STEP_LOG_LINE@json.output@{@@@",
"@@@STEP_LOG_LINE@json.output@ \"_number\": \"91827\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"branch\": \"main\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"change_id\": \"Ideadbeef\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"created\": \"2017-01-30 13:11:20.000000000\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"has_review_started\": false, @@@",
Add step test data for update_files() in Gerrit module Thus downstream recipes could run "train" without explicit mock data everywhere. BUG=1293270 TEST=train Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Change-Id: I09f6a27097f400dabd990f6ef61e301a75a39691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3502768 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Xinan Lin <linxinan@chromium.org>
4 years ago
"@@@STEP_LOG_LINE@json.output@ \"id\": \"fully~qualified~changeid\", @@@",
Return changeinfo from update_files method Users may need more info from a created/submitted change, e.g. revision hash, change status(submitted or not) etc. BUG=1236658 TEST=train Recipe-Nontrivial-Roll: chrome_release Change-Id: I1db57e5c6a4e58ea320526ef5f5cbb83e1b0bb60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3102579 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@google.com> Reviewed-by: Michael Moss <mmoss@chromium.org>
4 years ago
"@@@STEP_LOG_LINE@json.output@ \"project\": \"chromium/src\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"revisions\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"184ebe53805e102605d11f6b143486d15c23a09c\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"_number\": \"1\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"commit\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"message\": \"Change commit message\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@ }, @@@",
"@@@STEP_LOG_LINE@json.output@ \"status\": \"MERGED\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"subject\": \"Change title\"@@@",
"@@@STEP_LOG_LINE@json.output@}@@@",
"@@@STEP_LOG_END@json.output@@@"
]
Add new API to update files by gerrit module The new API here could support users to update files to remote repo without loading the source code to the bot. BUG=1207955 TEST=train Change-Id: I2970171bf5b58db0db41bab5a433fc6721b7b2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3042407 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
4 years ago
},
Enable query for changes in gerrit recipe module This'll allow to query gerrit from recipes for e.g. current changes in CQ. Bug: 685318 Change-Id: I73d08d4b186b2e5fe044fd4d4fafd9db62e27066 Reviewed-on: https://chromium-review.googlesource.com/558939 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
8 years ago
{
"cmd": [
recipes: use vpython3 in gerrit recipe modules This is to prevent failure like https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1057655/overview Bug: 1327534 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I922dddbd23eae0a02a95e020722b5edd1186ef77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3771540 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
3 years ago
"vpython3",
[recipes] Manual roll. Update "import DEPS" syntax and package_repo_resource. recipe_engine: https://crrev.com/a42dce4e0b0db8bd6b7688030e723197919306db [engine] Rewrite/simplify loading infrastructure. (iannucci@chromium.org) R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org Recipe-Manual-Change: skia Recipe-Manual-Change: skiabuildbot Recipe-Manual-Change: build Recipe-Manual-Change: build_limited_scripts_slave Recipe-Manual-Change: infra Recipe-Manual-Change: release_scripts Bug: 914992 Change-Id: Ie3a3be9124e1ca4abd5e79af2f8c946b3ce906ff Reviewed-on: https://chromium-review.googlesource.com/c/1464761 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
7 years ago
"RECIPE_REPO[depot_tools]/gerrit_client.py",
Enable query for changes in gerrit recipe module This'll allow to query gerrit from recipes for e.g. current changes in CQ. Bug: 685318 Change-Id: I73d08d4b186b2e5fe044fd4d4fafd9db62e27066 Reviewed-on: https://chromium-review.googlesource.com/558939 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
8 years ago
"changes",
Add timeouts to the actual http calls in gerrit_util.py When gerrit's availability drops, chrome's builds see an excessive amount of failures, eg: https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359780/overview https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359594/overview https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359564/overview https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359630/overview Seemingly all failures occur in either the `gerrit fetch current CL info` step or the `gerrit changes` step. Both steps have a 60s timeout and shell out to depot_tools' gerrit_client.py. That script essentially makes a single http call to gerrit. That request has no configured timeout. So when gerrit's MIA and the call hangs indefinitely, so too will the step hang. 60s after that, the step timeout is reached, and the entire build crashes with an infra-failure. However, one single retry has been shown to sufficiently work around at least one instance of that failure: https://luci-milo.appspot.com/raw/build/logs.chromium.org/chromium/led/bpastene_google.com/dea9a6eca2543e87ee356cedd9d105cdccd375906f690ce10a959701a8fb51ad/+/build.proto So this incorporates timeouts into the requests made by gerrit_util.py. Each request is given a 10s timeout, which should be enough for most/all gerrit calls. (Both steps have a p90 of less than 1sec.) When a timeout is reached, the script will automatically retry up to 4 times. This also bumps the timeouts of the step calls to gerrit_client.py to 6min since the script can now take up to 5 minutes to fail, ie: the sequence of sleeps is roughly 10s, 20s, 40s, 80s, 160s, which is about 5min. So a 6min timeout should cover all those retries. This also passes in "--verbose" to all step calls to this script, so the logging that prints out the retry + sleep log lines will be visible in build logs. Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Bug: 1432638 Change-Id: I9dc47f4beeda3783ae4f9152bd29ee441ac3e197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4420526 Reviewed-by: Joanna Wang <jojwang@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org>
2 years ago
"--verbose",
Enable query for changes in gerrit recipe module This'll allow to query gerrit from recipes for e.g. current changes in CQ. Bug: 685318 Change-Id: I73d08d4b186b2e5fe044fd4d4fafd9db62e27066 Reviewed-on: https://chromium-review.googlesource.com/558939 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
8 years ago
"--host",
Improve gerrit recipe_module example The /a suffix in the hots URL is not necessary as the gerrit_util adds it by default to authenticate. Having it hard-coded in the example can be misleading. Bug: 685318 Change-Id: I333cd8b2aa9020aadfd186f2e18fbff0aa917681 Reviewed-on: https://chromium-review.googlesource.com/564611 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
8 years ago
"https://chromium-review.googlesource.com",
Enable query for changes in gerrit recipe module This'll allow to query gerrit from recipes for e.g. current changes in CQ. Bug: 685318 Change-Id: I73d08d4b186b2e5fe044fd4d4fafd9db62e27066 Reviewed-on: https://chromium-review.googlesource.com/558939 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
8 years ago
"--json_file",
"/path/to/tmp/json",
"--start",
"1",
"--limit",
"1",
"-p",
"project=chromium/src",
"-p",
"status=open",
"-p",
"label=Commit-Queue>0"
],
"env": {
[recipes] Manual roll. Update "import DEPS" syntax and package_repo_resource. recipe_engine: https://crrev.com/a42dce4e0b0db8bd6b7688030e723197919306db [engine] Rewrite/simplify loading infrastructure. (iannucci@chromium.org) R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org Recipe-Manual-Change: skia Recipe-Manual-Change: skiabuildbot Recipe-Manual-Change: build Recipe-Manual-Change: build_limited_scripts_slave Recipe-Manual-Change: infra Recipe-Manual-Change: release_scripts Bug: 914992 Change-Id: Ie3a3be9124e1ca4abd5e79af2f8c946b3ce906ff Reviewed-on: https://chromium-review.googlesource.com/c/1464761 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
7 years ago
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
Enable query for changes in gerrit recipe module This'll allow to query gerrit from recipes for e.g. current changes in CQ. Bug: 685318 Change-Id: I73d08d4b186b2e5fe044fd4d4fafd9db62e27066 Reviewed-on: https://chromium-review.googlesource.com/558939 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
8 years ago
},
"infra_step": true,
"name": "gerrit changes",
"~followup_annotations": [
"@@@STEP_LOG_LINE@json.output@[@@@",
"@@@STEP_LOG_LINE@json.output@ {@@@",
Revert "bot_update: Specify the target branch for patch_refs." This reverts commit 01f0c698fb898168940718c5616ed3f6bb6c1b18. Reason for revert: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1211422 Original change's description: > bot_update: Specify the target branch for patch_refs. > > Bug: 870279 > Recipe-Manual-Change: build > Recipe-Manual-Change: infra > Recipe-Manual-Change: build_limited_scripts_slave > Recipe-Manual-Change: skia > Recipe-Manual-Change: release_scripts > Change-Id: I58110ff8c5a6ca6906bbbf3eafa09dcbaf39f777 > Reviewed-on: https://chromium-review.googlesource.com/1174988 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> TBR=tandrii@chromium.org,ehmaldonado@chromium.org,jbudorick@chromium.org Change-Id: Ic78a264ccf5e2ca15452659e17d41da264560eb8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870279 Reviewed-on: https://chromium-review.googlesource.com/1211462 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
7 years ago
"@@@STEP_LOG_LINE@json.output@ \"_number\": \"91827\", @@@",
Replace non-inclusive terms Bug: 1118410, 1118413, 1118422, 1118424, 1118426 Bug: 1118428, 1118430, 1118434, 1118438, 1118442 Bug: 1118453, 1118454 Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: build Change-Id: I43e6305f8c3136774f01b57f12bb442bcb863371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2551388 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
5 years ago
"@@@STEP_LOG_LINE@json.output@ \"branch\": \"main\", @@@",
Enable query for changes in gerrit recipe module This'll allow to query gerrit from recipes for e.g. current changes in CQ. Bug: 685318 Change-Id: I73d08d4b186b2e5fe044fd4d4fafd9db62e27066 Reviewed-on: https://chromium-review.googlesource.com/558939 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ \"change_id\": \"Ideadbeef\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"created\": \"2017-01-30 13:11:20.000000000\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"has_review_started\": false, @@@",
Add step test data for update_files() in Gerrit module Thus downstream recipes could run "train" without explicit mock data everywhere. BUG=1293270 TEST=train Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Change-Id: I09f6a27097f400dabd990f6ef61e301a75a39691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3502768 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Xinan Lin <linxinan@chromium.org>
4 years ago
"@@@STEP_LOG_LINE@json.output@ \"id\": \"fully~qualified~changeid\", @@@",
Enable query for changes in gerrit recipe module This'll allow to query gerrit from recipes for e.g. current changes in CQ. Bug: 685318 Change-Id: I73d08d4b186b2e5fe044fd4d4fafd9db62e27066 Reviewed-on: https://chromium-review.googlesource.com/558939 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ \"project\": \"chromium/src\", @@@",
tryserver: add support for gerrit footers Bug: 644609 Change-Id: Ied7439d688b89f90b9705968927521b5060c5fb4 Reviewed-on: https://chromium-review.googlesource.com/565564 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ \"revisions\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"184ebe53805e102605d11f6b143486d15c23a09c\": {@@@",
Revert "bot_update: Specify the target branch for patch_refs." This reverts commit 01f0c698fb898168940718c5616ed3f6bb6c1b18. Reason for revert: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1211422 Original change's description: > bot_update: Specify the target branch for patch_refs. > > Bug: 870279 > Recipe-Manual-Change: build > Recipe-Manual-Change: infra > Recipe-Manual-Change: build_limited_scripts_slave > Recipe-Manual-Change: skia > Recipe-Manual-Change: release_scripts > Change-Id: I58110ff8c5a6ca6906bbbf3eafa09dcbaf39f777 > Reviewed-on: https://chromium-review.googlesource.com/1174988 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> TBR=tandrii@chromium.org,ehmaldonado@chromium.org,jbudorick@chromium.org Change-Id: Ic78a264ccf5e2ca15452659e17d41da264560eb8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870279 Reviewed-on: https://chromium-review.googlesource.com/1211462 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
7 years ago
"@@@STEP_LOG_LINE@json.output@ \"_number\": \"1\", @@@",
tryserver: add support for gerrit footers Bug: 644609 Change-Id: Ied7439d688b89f90b9705968927521b5060c5fb4 Reviewed-on: https://chromium-review.googlesource.com/565564 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ \"commit\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"message\": \"Change commit message\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@ }, @@@",
"@@@STEP_LOG_LINE@json.output@ \"status\": \"NEW\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"subject\": \"Change title\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@]@@@",
"@@@STEP_LOG_END@json.output@@@"
]
},
Implemented suppport for getrelatedchanges endpoint in gerrit module The endpoint documentation can be found here: https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#get-related-changes This involved adding support for the command in gerrit_client and gerrit_util and then incorporating functionality and testing into the gerrit recipe module. The reasoning for this is to be able to identify chained builds for improved accuracy of the new test identification for the FLake Endorser project. Bug:1204163 Change-Id: Ic60c733540a9afd7ff159408b0ea9ad7aac078e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2928016 Commit-Queue: Marco Georgaklis <mgeorgaklis@google.com> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
4 years ago
{
"cmd": [
recipes: use vpython3 in gerrit recipe modules This is to prevent failure like https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1057655/overview Bug: 1327534 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I922dddbd23eae0a02a95e020722b5edd1186ef77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3771540 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
3 years ago
"vpython3",
Implemented suppport for getrelatedchanges endpoint in gerrit module The endpoint documentation can be found here: https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#get-related-changes This involved adding support for the command in gerrit_client and gerrit_util and then incorporating functionality and testing into the gerrit recipe module. The reasoning for this is to be able to identify chained builds for improved accuracy of the new test identification for the FLake Endorser project. Bug:1204163 Change-Id: Ic60c733540a9afd7ff159408b0ea9ad7aac078e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2928016 Commit-Queue: Marco Georgaklis <mgeorgaklis@google.com> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
4 years ago
"RECIPE_REPO[depot_tools]/gerrit_client.py",
"relatedchanges",
"--host",
"https://chromium-review.googlesource.com",
"--change",
"58478",
"--revision",
"2",
"--json_file",
"/path/to/tmp/json"
],
"env": {
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "gerrit relatedchanges",
"~followup_annotations": [
"@@@STEP_LOG_LINE@json.output@{@@@",
"@@@STEP_LOG_LINE@json.output@ \"changes\": [@@@",
"@@@STEP_LOG_LINE@json.output@ {@@@",
"@@@STEP_LOG_LINE@json.output@ \"_change_number\": 58478, @@@",
"@@@STEP_LOG_LINE@json.output@ \"_current_revision_number\": 2, @@@",
"@@@STEP_LOG_LINE@json.output@ \"_revision_number\": 2, @@@",
"@@@STEP_LOG_LINE@json.output@ \"change_id\": \"Ic62ae3103fca2214904dbf2faf4c861b5f0ae9b5\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"commit\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"author\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"date\": \"2014-07-12 15:04:24.000000000\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"email\": \"example@example.com\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"name\": \"Example Name\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"tz\": 120@@@",
"@@@STEP_LOG_LINE@json.output@ }, @@@",
"@@@STEP_LOG_LINE@json.output@ \"commit\": \"78847477532e386f5a2185a4e8c90b2509e354e3\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"parents\": [@@@",
"@@@STEP_LOG_LINE@json.output@ {@@@",
"@@@STEP_LOG_LINE@json.output@ \"commit\": \"bb499510bbcdbc9164d96b0dbabb4aa45f59a87e\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@ ], @@@",
"@@@STEP_LOG_LINE@json.output@ \"subject\": \"Remove Solr\"@@@",
"@@@STEP_LOG_LINE@json.output@ }, @@@",
"@@@STEP_LOG_LINE@json.output@ \"project\": \"gerrit\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"status\": \"NEW\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@ ]@@@",
"@@@STEP_LOG_LINE@json.output@}@@@",
"@@@STEP_LOG_END@json.output@@@"
]
},
tryserver: add support for gerrit footers Bug: 644609 Change-Id: Ied7439d688b89f90b9705968927521b5060c5fb4 Reviewed-on: https://chromium-review.googlesource.com/565564 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
{
"cmd": [
recipes: use vpython3 in gerrit recipe modules This is to prevent failure like https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1057655/overview Bug: 1327534 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I922dddbd23eae0a02a95e020722b5edd1186ef77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3771540 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
3 years ago
"vpython3",
[recipes] Manual roll. Update "import DEPS" syntax and package_repo_resource. recipe_engine: https://crrev.com/a42dce4e0b0db8bd6b7688030e723197919306db [engine] Rewrite/simplify loading infrastructure. (iannucci@chromium.org) R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org Recipe-Manual-Change: skia Recipe-Manual-Change: skiabuildbot Recipe-Manual-Change: build Recipe-Manual-Change: build_limited_scripts_slave Recipe-Manual-Change: infra Recipe-Manual-Change: release_scripts Bug: 914992 Change-Id: Ie3a3be9124e1ca4abd5e79af2f8c946b3ce906ff Reviewed-on: https://chromium-review.googlesource.com/c/1464761 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
7 years ago
"RECIPE_REPO[depot_tools]/gerrit_client.py",
tryserver: add support for gerrit footers Bug: 644609 Change-Id: Ied7439d688b89f90b9705968927521b5060c5fb4 Reviewed-on: https://chromium-review.googlesource.com/565564 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
"changes",
Add timeouts to the actual http calls in gerrit_util.py When gerrit's availability drops, chrome's builds see an excessive amount of failures, eg: https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359780/overview https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359594/overview https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359564/overview https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359630/overview Seemingly all failures occur in either the `gerrit fetch current CL info` step or the `gerrit changes` step. Both steps have a 60s timeout and shell out to depot_tools' gerrit_client.py. That script essentially makes a single http call to gerrit. That request has no configured timeout. So when gerrit's MIA and the call hangs indefinitely, so too will the step hang. 60s after that, the step timeout is reached, and the entire build crashes with an infra-failure. However, one single retry has been shown to sufficiently work around at least one instance of that failure: https://luci-milo.appspot.com/raw/build/logs.chromium.org/chromium/led/bpastene_google.com/dea9a6eca2543e87ee356cedd9d105cdccd375906f690ce10a959701a8fb51ad/+/build.proto So this incorporates timeouts into the requests made by gerrit_util.py. Each request is given a 10s timeout, which should be enough for most/all gerrit calls. (Both steps have a p90 of less than 1sec.) When a timeout is reached, the script will automatically retry up to 4 times. This also bumps the timeouts of the step calls to gerrit_client.py to 6min since the script can now take up to 5 minutes to fail, ie: the sequence of sleeps is roughly 10s, 20s, 40s, 80s, 160s, which is about 5min. So a 6min timeout should cover all those retries. This also passes in "--verbose" to all step calls to this script, so the logging that prints out the retry + sleep log lines will be visible in build logs. Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Bug: 1432638 Change-Id: I9dc47f4beeda3783ae4f9152bd29ee441ac3e197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4420526 Reviewed-by: Joanna Wang <jojwang@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org>
2 years ago
"--verbose",
tryserver: add support for gerrit footers Bug: 644609 Change-Id: Ied7439d688b89f90b9705968927521b5060c5fb4 Reviewed-on: https://chromium-review.googlesource.com/565564 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
"--host",
"https://chromium-review.googlesource.com",
"--json_file",
"/path/to/tmp/json",
"-p",
delete unused api.gerrit.get_change_destination_branch. Use api.tryserver.gerrit_change_target_ref instead. Depends on https://crrev.com/c/1359892 Change-Id: If8ec0bb262035239a1ef77093808196561050c9b Reviewed-on: https://chromium-review.googlesource.com/c/1359794 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
7 years ago
"project=chromium/src",
"-p",
"status=open",
"-p",
"label=Commit-Queue>2"
tryserver: add support for gerrit footers Bug: 644609 Change-Id: Ied7439d688b89f90b9705968927521b5060c5fb4 Reviewed-on: https://chromium-review.googlesource.com/565564 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
],
"env": {
[recipes] Manual roll. Update "import DEPS" syntax and package_repo_resource. recipe_engine: https://crrev.com/a42dce4e0b0db8bd6b7688030e723197919306db [engine] Rewrite/simplify loading infrastructure. (iannucci@chromium.org) R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org Recipe-Manual-Change: skia Recipe-Manual-Change: skiabuildbot Recipe-Manual-Change: build Recipe-Manual-Change: build_limited_scripts_slave Recipe-Manual-Change: infra Recipe-Manual-Change: release_scripts Bug: 914992 Change-Id: Ie3a3be9124e1ca4abd5e79af2f8c946b3ce906ff Reviewed-on: https://chromium-review.googlesource.com/c/1464761 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
7 years ago
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
tryserver: add support for gerrit footers Bug: 644609 Change-Id: Ied7439d688b89f90b9705968927521b5060c5fb4 Reviewed-on: https://chromium-review.googlesource.com/565564 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
},
"infra_step": true,
delete unused api.gerrit.get_change_destination_branch. Use api.tryserver.gerrit_change_target_ref instead. Depends on https://crrev.com/c/1359892 Change-Id: If8ec0bb262035239a1ef77093808196561050c9b Reviewed-on: https://chromium-review.googlesource.com/c/1359794 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
7 years ago
"name": "gerrit changes empty query",
tryserver: add support for gerrit footers Bug: 644609 Change-Id: Ied7439d688b89f90b9705968927521b5060c5fb4 Reviewed-on: https://chromium-review.googlesource.com/565564 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
"~followup_annotations": [
delete unused api.gerrit.get_change_destination_branch. Use api.tryserver.gerrit_change_target_ref instead. Depends on https://crrev.com/c/1359892 Change-Id: If8ec0bb262035239a1ef77093808196561050c9b Reviewed-on: https://chromium-review.googlesource.com/c/1359794 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
7 years ago
"@@@STEP_LOG_LINE@json.output@[]@@@",
Enable query for changes in gerrit recipe module This'll allow to query gerrit from recipes for e.g. current changes in CQ. Bug: 685318 Change-Id: I73d08d4b186b2e5fe044fd4d4fafd9db62e27066 Reviewed-on: https://chromium-review.googlesource.com/558939 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
8 years ago
"@@@STEP_LOG_END@json.output@@@"
]
},
Add support to query a CL's branch to gerrit recipe module Bug: 740456 Change-Id: Ic4f3c1f046cfa025d8e60172ee58e2b2e1b76ee6 Reviewed-on: https://chromium-review.googlesource.com/565560 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
8 years ago
{
"cmd": [
recipes: use vpython3 in gerrit recipe modules This is to prevent failure like https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1057655/overview Bug: 1327534 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I922dddbd23eae0a02a95e020722b5edd1186ef77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3771540 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
3 years ago
"vpython3",
[recipes] Manual roll. Update "import DEPS" syntax and package_repo_resource. recipe_engine: https://crrev.com/a42dce4e0b0db8bd6b7688030e723197919306db [engine] Rewrite/simplify loading infrastructure. (iannucci@chromium.org) R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org Recipe-Manual-Change: skia Recipe-Manual-Change: skiabuildbot Recipe-Manual-Change: build Recipe-Manual-Change: build_limited_scripts_slave Recipe-Manual-Change: infra Recipe-Manual-Change: release_scripts Bug: 914992 Change-Id: Ie3a3be9124e1ca4abd5e79af2f8c946b3ce906ff Reviewed-on: https://chromium-review.googlesource.com/c/1464761 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
7 years ago
"RECIPE_REPO[depot_tools]/gerrit_client.py",
Add support to query a CL's branch to gerrit recipe module Bug: 740456 Change-Id: Ic4f3c1f046cfa025d8e60172ee58e2b2e1b76ee6 Reviewed-on: https://chromium-review.googlesource.com/565560 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
8 years ago
"changes",
Add timeouts to the actual http calls in gerrit_util.py When gerrit's availability drops, chrome's builds see an excessive amount of failures, eg: https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359780/overview https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359594/overview https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359564/overview https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359630/overview Seemingly all failures occur in either the `gerrit fetch current CL info` step or the `gerrit changes` step. Both steps have a 60s timeout and shell out to depot_tools' gerrit_client.py. That script essentially makes a single http call to gerrit. That request has no configured timeout. So when gerrit's MIA and the call hangs indefinitely, so too will the step hang. 60s after that, the step timeout is reached, and the entire build crashes with an infra-failure. However, one single retry has been shown to sufficiently work around at least one instance of that failure: https://luci-milo.appspot.com/raw/build/logs.chromium.org/chromium/led/bpastene_google.com/dea9a6eca2543e87ee356cedd9d105cdccd375906f690ce10a959701a8fb51ad/+/build.proto So this incorporates timeouts into the requests made by gerrit_util.py. Each request is given a 10s timeout, which should be enough for most/all gerrit calls. (Both steps have a p90 of less than 1sec.) When a timeout is reached, the script will automatically retry up to 4 times. This also bumps the timeouts of the step calls to gerrit_client.py to 6min since the script can now take up to 5 minutes to fail, ie: the sequence of sleeps is roughly 10s, 20s, 40s, 80s, 160s, which is about 5min. So a 6min timeout should cover all those retries. This also passes in "--verbose" to all step calls to this script, so the logging that prints out the retry + sleep log lines will be visible in build logs. Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Bug: 1432638 Change-Id: I9dc47f4beeda3783ae4f9152bd29ee441ac3e197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4420526 Reviewed-by: Joanna Wang <jojwang@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org>
2 years ago
"--verbose",
Add support to query a CL's branch to gerrit recipe module Bug: 740456 Change-Id: Ic4f3c1f046cfa025d8e60172ee58e2b2e1b76ee6 Reviewed-on: https://chromium-review.googlesource.com/565560 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
8 years ago
"--host",
"https://chromium-review.googlesource.com",
"--json_file",
"/path/to/tmp/json",
"--limit",
"1",
"-p",
delete unused api.gerrit.get_change_destination_branch. Use api.tryserver.gerrit_change_target_ref instead. Depends on https://crrev.com/c/1359892 Change-Id: If8ec0bb262035239a1ef77093808196561050c9b Reviewed-on: https://chromium-review.googlesource.com/c/1359794 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
7 years ago
"change=123",
"-o",
"ALL_REVISIONS",
"-o",
"ALL_COMMITS"
Add support to query a CL's branch to gerrit recipe module Bug: 740456 Change-Id: Ic4f3c1f046cfa025d8e60172ee58e2b2e1b76ee6 Reviewed-on: https://chromium-review.googlesource.com/565560 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
8 years ago
],
"env": {
[recipes] Manual roll. Update "import DEPS" syntax and package_repo_resource. recipe_engine: https://crrev.com/a42dce4e0b0db8bd6b7688030e723197919306db [engine] Rewrite/simplify loading infrastructure. (iannucci@chromium.org) R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org Recipe-Manual-Change: skia Recipe-Manual-Change: skiabuildbot Recipe-Manual-Change: build Recipe-Manual-Change: build_limited_scripts_slave Recipe-Manual-Change: infra Recipe-Manual-Change: release_scripts Bug: 914992 Change-Id: Ie3a3be9124e1ca4abd5e79af2f8c946b3ce906ff Reviewed-on: https://chromium-review.googlesource.com/c/1464761 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
7 years ago
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
Add support to query a CL's branch to gerrit recipe module Bug: 740456 Change-Id: Ic4f3c1f046cfa025d8e60172ee58e2b2e1b76ee6 Reviewed-on: https://chromium-review.googlesource.com/565560 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
8 years ago
},
"infra_step": true,
delete unused api.gerrit.get_change_destination_branch. Use api.tryserver.gerrit_change_target_ref instead. Depends on https://crrev.com/c/1359892 Change-Id: If8ec0bb262035239a1ef77093808196561050c9b Reviewed-on: https://chromium-review.googlesource.com/c/1359794 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
7 years ago
"name": "gerrit changes (2)",
Add support to query a CL's branch to gerrit recipe module Bug: 740456 Change-Id: Ic4f3c1f046cfa025d8e60172ee58e2b2e1b76ee6 Reviewed-on: https://chromium-review.googlesource.com/565560 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
8 years ago
"~followup_annotations": [
"@@@STEP_LOG_LINE@json.output@[@@@",
"@@@STEP_LOG_LINE@json.output@ {@@@",
Provide step_test_data in gerrit.get_revision_info. This will reduce the need to manually mock steps: calls to get revision info will now return CLs that match the requested change and patchset numbers. Manually mocking will only be required if specific values for other field are desired or if the test case should not have revision info that matches the change and patchset. Change-Id: Ibc6ec62100616680e36d9a842449ac9c6fb2440b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2765162 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
5 years ago
"@@@STEP_LOG_LINE@json.output@ \"_number\": \"123\", @@@",
Replace non-inclusive terms Bug: 1118410, 1118413, 1118422, 1118424, 1118426 Bug: 1118428, 1118430, 1118434, 1118438, 1118442 Bug: 1118453, 1118454 Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: build Change-Id: I43e6305f8c3136774f01b57f12bb442bcb863371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2551388 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
5 years ago
"@@@STEP_LOG_LINE@json.output@ \"branch\": \"main\", @@@",
Add support to query a CL's branch to gerrit recipe module Bug: 740456 Change-Id: Ic4f3c1f046cfa025d8e60172ee58e2b2e1b76ee6 Reviewed-on: https://chromium-review.googlesource.com/565560 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ \"change_id\": \"Ideadbeef\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"created\": \"2017-01-30 13:11:20.000000000\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"has_review_started\": false, @@@",
Add step test data for update_files() in Gerrit module Thus downstream recipes could run "train" without explicit mock data everywhere. BUG=1293270 TEST=train Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Change-Id: I09f6a27097f400dabd990f6ef61e301a75a39691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3502768 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Xinan Lin <linxinan@chromium.org>
4 years ago
"@@@STEP_LOG_LINE@json.output@ \"id\": \"fully~qualified~changeid\", @@@",
Add support to query a CL's branch to gerrit recipe module Bug: 740456 Change-Id: Ic4f3c1f046cfa025d8e60172ee58e2b2e1b76ee6 Reviewed-on: https://chromium-review.googlesource.com/565560 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ \"project\": \"chromium/src\", @@@",
tryserver: add support for gerrit footers Bug: 644609 Change-Id: Ied7439d688b89f90b9705968927521b5060c5fb4 Reviewed-on: https://chromium-review.googlesource.com/565564 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ \"revisions\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"184ebe53805e102605d11f6b143486d15c23a09c\": {@@@",
Revert "bot_update: Specify the target branch for patch_refs." This reverts commit 01f0c698fb898168940718c5616ed3f6bb6c1b18. Reason for revert: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1211422 Original change's description: > bot_update: Specify the target branch for patch_refs. > > Bug: 870279 > Recipe-Manual-Change: build > Recipe-Manual-Change: infra > Recipe-Manual-Change: build_limited_scripts_slave > Recipe-Manual-Change: skia > Recipe-Manual-Change: release_scripts > Change-Id: I58110ff8c5a6ca6906bbbf3eafa09dcbaf39f777 > Reviewed-on: https://chromium-review.googlesource.com/1174988 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> TBR=tandrii@chromium.org,ehmaldonado@chromium.org,jbudorick@chromium.org Change-Id: Ic78a264ccf5e2ca15452659e17d41da264560eb8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870279 Reviewed-on: https://chromium-review.googlesource.com/1211462 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
7 years ago
"@@@STEP_LOG_LINE@json.output@ \"_number\": \"1\", @@@",
tryserver: add support for gerrit footers Bug: 644609 Change-Id: Ied7439d688b89f90b9705968927521b5060c5fb4 Reviewed-on: https://chromium-review.googlesource.com/565564 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ \"commit\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"message\": \"Change commit message\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@ }, @@@",
Add support to query a CL's branch to gerrit recipe module Bug: 740456 Change-Id: Ic4f3c1f046cfa025d8e60172ee58e2b2e1b76ee6 Reviewed-on: https://chromium-review.googlesource.com/565560 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ \"status\": \"NEW\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"subject\": \"Change title\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@]@@@",
"@@@STEP_LOG_END@json.output@@@"
]
},
Add a 'setlabel' command to gerrit_client.py And add a hook for it in the gerrit recipe_module. This will allow invocations of gerrit_client to set votes like "code-review-1" or "commit-queue+1" on CLs. This will be used by bots to control CLs they just created with update_files(). Bug: 1250084 Change-Id: I888458983165fed5882e5c37cba4a69dbfb9b810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3207266 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
4 years ago
{
"cmd": [
recipes: use vpython3 in gerrit recipe modules This is to prevent failure like https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1057655/overview Bug: 1327534 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I922dddbd23eae0a02a95e020722b5edd1186ef77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3771540 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
3 years ago
"vpython3",
Add a 'setlabel' command to gerrit_client.py And add a hook for it in the gerrit recipe_module. This will allow invocations of gerrit_client to set votes like "code-review-1" or "commit-queue+1" on CLs. This will be used by bots to control CLs they just created with update_files(). Bug: 1250084 Change-Id: I888458983165fed5882e5c37cba4a69dbfb9b810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3207266 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
4 years ago
"RECIPE_REPO[depot_tools]/gerrit_client.py",
"setlabel",
"--host",
"https://chromium-review.googlesource.com",
"--change",
"123",
"--json_file",
"/path/to/tmp/json",
"-l",
"code-review",
"-1"
],
"env": {
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "gerrit setlabel",
"~followup_annotations": [
"@@@STEP_LOG_END@json.output (invalid)@@@",
"@@@STEP_LOG_LINE@json.output (exception)@No JSON object could be decoded@@@",
"@@@STEP_LOG_END@json.output (exception)@@@"
]
},
{
"cmd": [
recipes: use vpython3 in gerrit recipe modules This is to prevent failure like https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1057655/overview Bug: 1327534 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I922dddbd23eae0a02a95e020722b5edd1186ef77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3771540 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
3 years ago
"vpython3",
Add a 'setlabel' command to gerrit_client.py And add a hook for it in the gerrit recipe_module. This will allow invocations of gerrit_client to set votes like "code-review-1" or "commit-queue+1" on CLs. This will be used by bots to control CLs they just created with update_files(). Bug: 1250084 Change-Id: I888458983165fed5882e5c37cba4a69dbfb9b810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3207266 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
4 years ago
"RECIPE_REPO[depot_tools]/gerrit_client.py",
"setlabel",
"--host",
"https://chromium-review.googlesource.com",
"--change",
"123",
"--json_file",
"/path/to/tmp/json",
"-l",
"commit-queue",
"1"
],
"env": {
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "gerrit setlabel (2)",
"~followup_annotations": [
"@@@STEP_LOG_END@json.output (invalid)@@@",
"@@@STEP_LOG_LINE@json.output (exception)@No JSON object could be decoded@@@",
"@@@STEP_LOG_END@json.output (exception)@@@"
]
},
Add gerrit.abandon_change command R=tandrii@chromium.org Bug: 935715 Change-Id: Ia7b8e2b187b59680270d694b24edf82493d1ed5c Reviewed-on: https://chromium-review.googlesource.com/c/1487212 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
7 years ago
{
"cmd": [
recipes: use vpython3 in gerrit recipe modules This is to prevent failure like https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1057655/overview Bug: 1327534 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I922dddbd23eae0a02a95e020722b5edd1186ef77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3771540 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
3 years ago
"vpython3",
Add gerrit.abandon_change command R=tandrii@chromium.org Bug: 935715 Change-Id: Ia7b8e2b187b59680270d694b24edf82493d1ed5c Reviewed-on: https://chromium-review.googlesource.com/c/1487212 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
7 years ago
"RECIPE_REPO[depot_tools]/gerrit_client.py",
"abandon",
"--host",
"https://chromium-review.googlesource.com",
"--change",
"123",
"--json_file",
"/path/to/tmp/json",
"--message",
"bad roll"
],
"env": {
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
},
"infra_step": true,
"name": "gerrit abandon",
"~followup_annotations": [
"@@@STEP_LOG_LINE@json.output@[@@@",
"@@@STEP_LOG_LINE@json.output@ {@@@",
"@@@STEP_LOG_LINE@json.output@ \"_number\": \"123\", @@@",
Replace non-inclusive terms Bug: 1118410, 1118413, 1118422, 1118424, 1118426 Bug: 1118428, 1118430, 1118434, 1118438, 1118442 Bug: 1118453, 1118454 Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: build Change-Id: I43e6305f8c3136774f01b57f12bb442bcb863371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2551388 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
5 years ago
"@@@STEP_LOG_LINE@json.output@ \"branch\": \"main\", @@@",
Add gerrit.abandon_change command R=tandrii@chromium.org Bug: 935715 Change-Id: Ia7b8e2b187b59680270d694b24edf82493d1ed5c Reviewed-on: https://chromium-review.googlesource.com/c/1487212 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
7 years ago
"@@@STEP_LOG_LINE@json.output@ \"change_id\": \"Ideadbeef\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"created\": \"2017-01-30 13:11:20.000000000\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"has_review_started\": false, @@@",
Add step test data for update_files() in Gerrit module Thus downstream recipes could run "train" without explicit mock data everywhere. BUG=1293270 TEST=train Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Change-Id: I09f6a27097f400dabd990f6ef61e301a75a39691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3502768 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Xinan Lin <linxinan@chromium.org>
4 years ago
"@@@STEP_LOG_LINE@json.output@ \"id\": \"fully~qualified~changeid\", @@@",
Add gerrit.abandon_change command R=tandrii@chromium.org Bug: 935715 Change-Id: Ia7b8e2b187b59680270d694b24edf82493d1ed5c Reviewed-on: https://chromium-review.googlesource.com/c/1487212 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
7 years ago
"@@@STEP_LOG_LINE@json.output@ \"project\": \"chromium/src\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"revisions\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"184ebe53805e102605d11f6b143486d15c23a09c\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"_number\": \"1\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"commit\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"message\": \"Change commit message\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@ }, @@@",
"@@@STEP_LOG_LINE@json.output@ \"status\": \"ABANDONED\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"subject\": \"Change title\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@]@@@",
"@@@STEP_LOG_END@json.output@@@"
]
},
tryserver: add support for gerrit footers Bug: 644609 Change-Id: Ied7439d688b89f90b9705968927521b5060c5fb4 Reviewed-on: https://chromium-review.googlesource.com/565564 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
{
"cmd": [
recipes: use vpython3 in gerrit recipe modules This is to prevent failure like https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/1057655/overview Bug: 1327534 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I922dddbd23eae0a02a95e020722b5edd1186ef77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3771540 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
3 years ago
"vpython3",
[recipes] Manual roll. Update "import DEPS" syntax and package_repo_resource. recipe_engine: https://crrev.com/a42dce4e0b0db8bd6b7688030e723197919306db [engine] Rewrite/simplify loading infrastructure. (iannucci@chromium.org) R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org Recipe-Manual-Change: skia Recipe-Manual-Change: skiabuildbot Recipe-Manual-Change: build Recipe-Manual-Change: build_limited_scripts_slave Recipe-Manual-Change: infra Recipe-Manual-Change: release_scripts Bug: 914992 Change-Id: Ie3a3be9124e1ca4abd5e79af2f8c946b3ce906ff Reviewed-on: https://chromium-review.googlesource.com/c/1464761 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
7 years ago
"RECIPE_REPO[depot_tools]/gerrit_client.py",
tryserver: add support for gerrit footers Bug: 644609 Change-Id: Ied7439d688b89f90b9705968927521b5060c5fb4 Reviewed-on: https://chromium-review.googlesource.com/565564 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
"changes",
Add timeouts to the actual http calls in gerrit_util.py When gerrit's availability drops, chrome's builds see an excessive amount of failures, eg: https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359780/overview https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359594/overview https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359564/overview https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1359630/overview Seemingly all failures occur in either the `gerrit fetch current CL info` step or the `gerrit changes` step. Both steps have a 60s timeout and shell out to depot_tools' gerrit_client.py. That script essentially makes a single http call to gerrit. That request has no configured timeout. So when gerrit's MIA and the call hangs indefinitely, so too will the step hang. 60s after that, the step timeout is reached, and the entire build crashes with an infra-failure. However, one single retry has been shown to sufficiently work around at least one instance of that failure: https://luci-milo.appspot.com/raw/build/logs.chromium.org/chromium/led/bpastene_google.com/dea9a6eca2543e87ee356cedd9d105cdccd375906f690ce10a959701a8fb51ad/+/build.proto So this incorporates timeouts into the requests made by gerrit_util.py. Each request is given a 10s timeout, which should be enough for most/all gerrit calls. (Both steps have a p90 of less than 1sec.) When a timeout is reached, the script will automatically retry up to 4 times. This also bumps the timeouts of the step calls to gerrit_client.py to 6min since the script can now take up to 5 minutes to fail, ie: the sequence of sleeps is roughly 10s, 20s, 40s, 80s, 160s, which is about 5min. So a 6min timeout should cover all those retries. This also passes in "--verbose" to all step calls to this script, so the logging that prints out the retry + sleep log lines will be visible in build logs. Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Bug: 1432638 Change-Id: I9dc47f4beeda3783ae4f9152bd29ee441ac3e197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4420526 Reviewed-by: Joanna Wang <jojwang@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org>
2 years ago
"--verbose",
tryserver: add support for gerrit footers Bug: 644609 Change-Id: Ied7439d688b89f90b9705968927521b5060c5fb4 Reviewed-on: https://chromium-review.googlesource.com/565564 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
"--host",
"https://chromium-review.googlesource.com",
"--json_file",
"/path/to/tmp/json",
"--limit",
"1",
"-p",
recipes: cache destination branch of a Gerrit change. It doesn't change after change is created. R=jchinlee@chromium.org Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited_scripts_slave Change-Id: I4c4758085f6cfa7c2ef5267c6c71c9b324263f95 Reviewed-on: https://chromium-review.googlesource.com/1029227 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
7 years ago
"change=122",
tryserver: add support for gerrit footers Bug: 644609 Change-Id: Ied7439d688b89f90b9705968927521b5060c5fb4 Reviewed-on: https://chromium-review.googlesource.com/565564 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
"-o",
"ALL_REVISIONS",
"-o",
"ALL_COMMITS"
],
"env": {
[recipes] Manual roll. Update "import DEPS" syntax and package_repo_resource. recipe_engine: https://crrev.com/a42dce4e0b0db8bd6b7688030e723197919306db [engine] Rewrite/simplify loading infrastructure. (iannucci@chromium.org) R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org Recipe-Manual-Change: skia Recipe-Manual-Change: skiabuildbot Recipe-Manual-Change: build Recipe-Manual-Change: build_limited_scripts_slave Recipe-Manual-Change: infra Recipe-Manual-Change: release_scripts Bug: 914992 Change-Id: Ie3a3be9124e1ca4abd5e79af2f8c946b3ce906ff Reviewed-on: https://chromium-review.googlesource.com/c/1464761 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
7 years ago
"PATH": "<PATH>:RECIPE_REPO[depot_tools]"
tryserver: add support for gerrit footers Bug: 644609 Change-Id: Ied7439d688b89f90b9705968927521b5060c5fb4 Reviewed-on: https://chromium-review.googlesource.com/565564 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
},
"infra_step": true,
Revert "bot_update: Specify the target branch for patch_refs." This reverts commit 01f0c698fb898168940718c5616ed3f6bb6c1b18. Reason for revert: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1211422 Original change's description: > bot_update: Specify the target branch for patch_refs. > > Bug: 870279 > Recipe-Manual-Change: build > Recipe-Manual-Change: infra > Recipe-Manual-Change: build_limited_scripts_slave > Recipe-Manual-Change: skia > Recipe-Manual-Change: release_scripts > Change-Id: I58110ff8c5a6ca6906bbbf3eafa09dcbaf39f777 > Reviewed-on: https://chromium-review.googlesource.com/1174988 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> TBR=tandrii@chromium.org,ehmaldonado@chromium.org,jbudorick@chromium.org Change-Id: Ic78a264ccf5e2ca15452659e17d41da264560eb8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870279 Reviewed-on: https://chromium-review.googlesource.com/1211462 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
7 years ago
"name": "gerrit changes (3)",
tryserver: add support for gerrit footers Bug: 644609 Change-Id: Ied7439d688b89f90b9705968927521b5060c5fb4 Reviewed-on: https://chromium-review.googlesource.com/565564 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
"~followup_annotations": [
Provide step_test_data in gerrit.get_revision_info. This will reduce the need to manually mock steps: calls to get revision info will now return CLs that match the requested change and patchset numbers. Manually mocking will only be required if specific values for other field are desired or if the test case should not have revision info that matches the change and patchset. Change-Id: Ibc6ec62100616680e36d9a842449ac9c6fb2440b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2765162 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
5 years ago
"@@@STEP_LOG_LINE@json.output@[]@@@",
tryserver: add support for gerrit footers Bug: 644609 Change-Id: Ied7439d688b89f90b9705968927521b5060c5fb4 Reviewed-on: https://chromium-review.googlesource.com/565564 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
"@@@STEP_LOG_END@json.output@@@"
]
},
Create recipe_modules/gerrit to interact with gerrit REST API BUG= R=mmoss,agable Change-Id: I6410c28280ed05cf384a3da93e6b154c6081e039 Reviewed-on: https://chromium-review.googlesource.com/427375 Reviewed-by: Michael Moss <mmoss@chromium.org>
9 years ago
{
Manual roll for new run logic Manual roll for https://crrev.com/c/1239574/ TBR=iannucci Recipe-Manual-Change: build Recipe-Manual-Change: infra Recipe-Manual-Change: build_limited_scripts_slave Recipe-Manual-Change: release_scripts Recipe-Manual-Change: skiabuildbot Recipe-Manual-Change: skia Bug: 646142 Change-Id: I56f156c05a695cfb00b9e0a7f335d516153a70c7 Reviewed-on: https://chromium-review.googlesource.com/c/1305041 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
7 years ago
"failure": {
Roll recipe dependencies (nontrivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/3f3879c37865ac94e52e8d91a70399ca37ae4fb8 Make aggregated InfraFailures surface as exceptions. (joshuaseaton@google.com) R=iannucci@chromium.org, martiniss@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I1ce8de0ea0660d734f553d18a051ba0552d263e5 Reviewed-on: https://chromium-review.googlesource.com/c/1382977 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
7 years ago
"humanReason": "1 out of 1 aggregated steps failed: Error querying for CL description: host:'https://chromium-review.googlesource.com' change:122; patchset:3"
Manual roll for new run logic Manual roll for https://crrev.com/c/1239574/ TBR=iannucci Recipe-Manual-Change: build Recipe-Manual-Change: infra Recipe-Manual-Change: build_limited_scripts_slave Recipe-Manual-Change: release_scripts Recipe-Manual-Change: skiabuildbot Recipe-Manual-Change: skia Bug: 646142 Change-Id: I56f156c05a695cfb00b9e0a7f335d516153a70c7 Reviewed-on: https://chromium-review.googlesource.com/c/1305041 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
7 years ago
},
"name": "$result"
Create recipe_modules/gerrit to interact with gerrit REST API BUG= R=mmoss,agable Change-Id: I6410c28280ed05cf384a3da93e6b154c6081e039 Reviewed-on: https://chromium-review.googlesource.com/427375 Reviewed-by: Michael Moss <mmoss@chromium.org>
9 years ago
}
]