aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '26bc518eae'
${ noResults }
depot_tools/recipes/recipe_modules/bot_update/examples/full.expected/basic.json

129 lines
6.8 KiB
JSON
Raw Normal View History Unescape Escape

depot_tools: import bot_update gclient git rietveld tryserver recipe modules (reland #1) Previous attempt: https://codereview.chromium.org/1642023002 TBR=martiniss BUG=582074 Review URL: https://codereview.chromium.org/1651033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298519 0039d316-1c4b-4281-b951-d872f2087c98
10 years ago
[
{
"cmd": [
Replace python3 with vpython in bot_update/api.py For context see comments 5 and 6 here: https://bugs.chromium.org/p/chromium/issues/detail?id=1298922#c6 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Bug: chromium:1298922 Change-Id: I23eaec3c104c7b52653732b6fd9d58d175d78069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3489327 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Ravi Mistry <rmistry@chromium.org>
4 years ago
"vpython3",
depot_tools: import bot_update gclient git rietveld tryserver recipe modules (reland #1) Previous attempt: https://codereview.chromium.org/1642023002 TBR=martiniss BUG=582074 Review URL: https://codereview.chromium.org/1651033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298519 0039d316-1c4b-4281-b951-d872f2087c98
10 years ago
"-u",
Roll recipe dependencies (nontrivial). recipe_engine -> 44b384f9b4f1085e9cfe43ea6308735a3af8d4e5: RELAND of Make the recipe engine allow modules named the same thing to co-exist. R=martiniss@chromium.org,luqui@chromium.org TBR=iannucci@chromium.org BUG=582280 Review URL: https://codereview.chromium.org/1660163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298530 0039d316-1c4b-4281-b951-d872f2087c98
10 years ago
"RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",
[bot_update] Pass spec as file. "bot_update" currently passes a full "gclient" specification as a command-line argument to "bot_update.py". This file contains all sorts of junk that clutters the command-line, and revealed a batch file escaping bug that seems to be present in the recipe engine. Change this so that "bot_update" passes the spec as file content instead of a command-line flag. Also, "bot_update" apparently called "--spec", which optparse kindly recognized as the real flag, "--specs". This has always(?) been a bug, and is no longer a problem. BUG=chromium:738348 TEST=expectations Change-Id: I5324b94dd5ef78503e7cfdc28b5fde8f434e4359 Reviewed-on: https://chromium-review.googlesource.com/558207 Reviewed-by: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org>
8 years ago
"--spec-path",
Revert "Remove unused functionality in bot_update.py" This reverts commit 8b64ddec2a54503ca802a545cd19ca368ab27448. Reason for revert: it appears we need this, since .DEPS.git specifies custom dependencies needed for tryjob. Original change's description: > Remove unused functionality in bot_update.py > > .DEPS.git has been removed in 2014 and no longer supported. It was > deleted in https://codereview.chromium.org/497313003 (August 2014). Last > entry in chromium/src is from tag 44.0.2403.47 in June 2015. > > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: build_limited > Recipe-Nontrivial-Roll: chrome_release > Recipe-Nontrivial-Roll: chromiumos > Recipe-Nontrivial-Roll: infra > Change-Id: I3ffb8813af867df959098c02d399c8d745894aae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3439573 > Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com> > Commit-Queue: Josip Sokcevic <sokcevic@google.com> Change-Id: I36bcd352a984b4b762096197a384e86347418290 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3448707 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
4 years ago
"cache_dir = '[CACHE]/git'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True, 'name': 'src', 'url': 'https://chromium.googlesource.com/chromium/src.git'}]",
depot_tools: import bot_update gclient git rietveld tryserver recipe modules (reland #1) Previous attempt: https://codereview.chromium.org/1642023002 TBR=martiniss BUG=582074 Review URL: https://codereview.chromium.org/1651033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298519 0039d316-1c4b-4281-b951-d872f2087c98
10 years ago
"--revision_mapping_file",
Fix bot_update example This adds angle to the got_revision_mapping to take account of the checked out revision and use it correctly in the without-patch application. This just adds the got_revision property to all test cases in the output and fixes the second bot_update run of two angle test cases. Bug: 740456 Change-Id: I6ae6bf627653280bc2a94230ec77949411dc4331 Reviewed-on: https://chromium-review.googlesource.com/573741 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
8 years ago
"{\"got_angle_revision\": \"src/third_party/angle\", \"got_cr_revision\": \"src\", \"got_revision\": \"src\", \"got_v8_revision\": \"src/v8\"}",
bot_update: make location of git cache configurable Depends on https://codereview.chromium.org/1667713002 BUG=583626 Review URL: https://codereview.chromium.org/1663493005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298552 0039d316-1c4b-4281-b951-d872f2087c98
10 years ago
"--git-cache-dir",
Remove infra_paths module. We no longer need it to bridge path differences between buildbot and LUCI, and it shouldn't be in use downstream now either. R=machenbach@chromium.org, martiniss@chromium.org, tandrii@chromium.org, yiwzhang@google.com Bug: 1015181 Change-Id: Iaba2100653ae9f06799d1d510bef993f7f710dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2220171 Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
5 years ago
"[CACHE]/git",
Add cleanup dir, use with bot_update. Currently, "bot_update" relies on a BuildBot cleanup mechanism and, to a lesser extent, the standard BuildBot directory layout. Both of these are problematic when projecting it into other circumstances, notably "remote_run" and LUCI. Have "bot_update" handle its own cleanup. It will now choose a cleanup directory within the hierarchy of its checkout, and explicitly purge it prior to execution if it exists. This enforces its expected behavior in all circumstances and removes its expectations of the greater checkout layout. Export "cleanup_dir" via "infra_paths" to point to "build.dead" when running on BuildBot builds. Otherwise, it is a default directory which, on Kitchen, is ephemeral by design. BUG=chromium:725631 TEST=expectations Change-Id: I664434c542a25aaa7ff3eac216208a2425730fde Reviewed-on: https://chromium-review.googlesource.com/528057 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
8 years ago
"--cleanup-dir",
"[CLEANUP]/bot_update",
depot_tools: import bot_update gclient git rietveld tryserver recipe modules (reland #1) Previous attempt: https://codereview.chromium.org/1642023002 TBR=martiniss BUG=582074 Review URL: https://codereview.chromium.org/1651033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298519 0039d316-1c4b-4281-b951-d872f2087c98
10 years ago
"--output_json",
"/path/to/tmp/json",
"--revision",
[bot_update] Update examples to use buildbucket module Update bot_update full.py example to use buildbucket module. Also remove buidlbucket example. Bug: 694348 Change-Id: Ib784583e0ded5ac95fabe99bc39a53f4646e80fc Reviewed-on: https://chromium-review.googlesource.com/1231281 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
7 years ago
"src@2d72510e447ab60a9728aeea2362d8be2cbd7789",
Reland "Fetch the input commit ref when both ref and id are specified." This is a reland of 72a245e4c678f478bf7e1961cae8b2ba5bfa93bf The "git checkout master --detach" operation has been modified to run in the solution directory. Original change's description: > Fetch the input commit ref when both ref and id are specified. > > This causes --refs refs/head/master to be added to bot_update calls when > the input build message contains a commit id and the refs/head/master > ref. This is an effective no-op. > > When bot_update clones a git repository, it results in HEAD referring to > master in contrast to the non-clone case which results in a detached > HEAD. This prevents fetching refs/heads/master, so detach the HEAD after > cloning. > > Bug: 922150 > Change-Id: I357a78305020218e9f5d350832a706b8f2b27967 > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Recipe-Nontrivial-Roll: infra > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900735 > Commit-Queue: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Bug: 922150 Change-Id: I7dc6ebed2dcbd880ff4d515f7e9fc6428ff24099 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: infra Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1910260 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
6 years ago
"--refs",
Remove unused arguments from bot_update recipe gclient removed syntax validation flag in 2020: https://crrev.com/c/2083589, so this can safely be removed. R=aravindvasudev@google.com, gavinmak@google.com Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: build Change-Id: I2aced6cdb01d571ca361cc57e7c8715c9ca40552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3419278 Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
4 years ago
"refs/heads/main"
depot_tools: import bot_update gclient git rietveld tryserver recipe modules (reland #1) Previous attempt: https://codereview.chromium.org/1642023002 TBR=martiniss BUG=582074 Review URL: https://codereview.chromium.org/1651033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298519 0039d316-1c4b-4281-b951-d872f2087c98
10 years ago
],
Set git low speed detection on bot_update Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: release_scripts Recipe-Nontrivial-Roll: skia Change-Id: Iacf276bd53fdca37994b6d6fe1e5db71f844a3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2147833 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Anthony Polito <apolito@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
5 years ago
"env": {
bot_update: Set DEPOT_TOOLS_REPORT_BUILD to report bot metrics. Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: chrome_release Change-Id: I704ac523a3212ea30061948f8a9971a373d5394f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2861214 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
4 years ago
"DEPOT_TOOLS_REPORT_BUILD": "chromium/src/ci/linux/8945511751514863184",
Set git low speed detection on bot_update Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: release_scripts Recipe-Nontrivial-Roll: skia Change-Id: Iacf276bd53fdca37994b6d6fe1e5db71f844a3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2147833 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Anthony Polito <apolito@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
5 years ago
"GIT_HTTP_LOW_SPEED_LIMIT": "102400",
Increase bot_update http low speed time Windows builders have issues fetching from chromium/src, and increasing timeout may help - recommended by git team. Bug: 1198581 Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: build Change-Id: Ic650dea2a175e9642a6d3d5b8f1c54fa9979e12a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2823020 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
"GIT_HTTP_LOW_SPEED_TIME": "1800"
Set git low speed detection on bot_update Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: release_scripts Recipe-Nontrivial-Roll: skia Change-Id: Iacf276bd53fdca37994b6d6fe1e5db71f844a3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2147833 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Anthony Polito <apolito@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
5 years ago
},
Roll recipe dependencies (nontrivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/e7fec5ccb9e70bf17b7878e63052a874afa06856 Change is_luci default to True. (mmoss@google.com) R=recipe-roller@chromium.org, tandrii@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9eb8913a8f65b8f107e5856c46aceda10e14c00c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1752476 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
6 years ago
"env_suffixes": {
Set DEPOT_TOOLS_UPDATE='0' assuming depot_tool do not auto update on bot Bug: 1090603 Change-Id: Ib42c778c69588e44ce95b58eda5bc06b12550e9e Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: skia Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2228810 Commit-Queue: Arthur Wang <wuwang@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
5 years ago
"DEPOT_TOOLS_UPDATE": [
"0"
],
[bot_update] Prefix PATH, cleanup. Prefix "depot_tools" to PATH instead of appending. This will ensure that "depot_tools" pulls resources from the recipe checkout as a preference, not as a last resort. Use "env_prefixes" instead of "env" to prefix PATH. Remove Git speed limit settings, which are taken care of by the Git wrapper now. BUG=chromium:738176 TEST=expectations R=hinoka@chromium.org, iannucci@chromium.org Change-Id: I2e509a331266e867be323bc70e3bc0f08f85246f Reviewed-on: https://chromium-review.googlesource.com/556287 Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org>
8 years ago
"PATH": [
[recipes] Manual roll. Update "import DEPS" syntax and package_repo_resource. recipe_engine: https://crrev.com/a42dce4e0b0db8bd6b7688030e723197919306db [engine] Rewrite/simplify loading infrastructure. (iannucci@chromium.org) R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org Recipe-Manual-Change: skia Recipe-Manual-Change: skiabuildbot Recipe-Manual-Change: build Recipe-Manual-Change: build_limited_scripts_slave Recipe-Manual-Change: infra Recipe-Manual-Change: release_scripts Bug: 914992 Change-Id: Ie3a3be9124e1ca4abd5e79af2f8c946b3ce906ff Reviewed-on: https://chromium-review.googlesource.com/c/1464761 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
7 years ago
"RECIPE_REPO[depot_tools]"
[bot_update] Prefix PATH, cleanup. Prefix "depot_tools" to PATH instead of appending. This will ensure that "depot_tools" pulls resources from the recipe checkout as a preference, not as a last resort. Use "env_prefixes" instead of "env" to prefix PATH. Remove Git speed limit settings, which are taken care of by the Git wrapper now. BUG=chromium:738176 TEST=expectations R=hinoka@chromium.org, iannucci@chromium.org Change-Id: I2e509a331266e867be323bc70e3bc0f08f85246f Reviewed-on: https://chromium-review.googlesource.com/556287 Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org>
8 years ago
]
bot_update: add depot_tools to PATH so that e.g. apply_issue can be found (reland #1) Original attempt: https://codereview.chromium.org/1660943002 Now adds depot_tools at the end of PATH to avoid issues with python on Windows. TBR=jochen BUG=437264 Review URL: https://codereview.chromium.org/1661953002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298562 0039d316-1c4b-4281-b951-d872f2087c98
10 years ago
},
Roll recipe dependencies (nontrivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM as normal. The recipe roller will *NOT* CQ the change itself, so you must CQ the change manually. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/05a33f9dcf2289bbaf233fcae1e2fb508d95f528 Record infra_step in recipe expectations (phajdan.jr@chromium.org) R=phajdan.jr@chromium.org Change-Id: Ic1202d82b7bb4376976c1b4989cbbd7d26d7c531 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://chromium-review.googlesource.com/454341 Commit-Queue: <recipe-roller@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
9 years ago
"infra_step": true,
Roll recipe dependencies (nontrivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8835439534712066113 Please review the expectation changes, and LGTM+CQ. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+log/63c685b8721140415e55e8756a5026ff5349dfc6~..f28ac0ab20025138a3f46845de09d625960c2a97 63c685b (chanli@chromium.org) [buildbucket] test_api: emulate luci_context based on build info f28ac0a (chanli@chromium.org) Reland "[recipe-py] expose resultdb info in LUCI_CONTEXT" More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=nodir@chromium.org, tandrii@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: If2d4beb72d786f852feca9f4d43e08778bf71f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3174366 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Auto-Submit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
4 years ago
"luci_context": {
"realm": {
"name": "chromium/src:ci"
},
"resultdb": {
"current_invocation": {
"name": "invocations/build:8945511751514863184",
"update_token": "token"
},
"hostname": "rdbhost"
}
},
depot_tools: import bot_update gclient git rietveld tryserver recipe modules (reland #1) Previous attempt: https://codereview.chromium.org/1642023002 TBR=martiniss BUG=582074 Review URL: https://codereview.chromium.org/1651033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298519 0039d316-1c4b-4281-b951-d872f2087c98
10 years ago
"name": "bot_update (without patch)",
"~followup_annotations": [
"@@@STEP_TEXT@Some step text@@@",
"@@@STEP_LOG_LINE@json.output@{@@@",
"@@@STEP_LOG_LINE@json.output@ \"did_run\": true, @@@",
"@@@STEP_LOG_LINE@json.output@ \"fixed_revisions\": {@@@",
[bot_update] Update examples to use buildbucket module Update bot_update full.py example to use buildbucket module. Also remove buidlbucket example. Bug: 694348 Change-Id: Ib784583e0ded5ac95fabe99bc39a53f4646e80fc Reviewed-on: https://chromium-review.googlesource.com/1231281 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
7 years ago
"@@@STEP_LOG_LINE@json.output@ \"src\": \"2d72510e447ab60a9728aeea2362d8be2cbd7789\"@@@",
depot_tools: import bot_update gclient git rietveld tryserver recipe modules (reland #1) Previous attempt: https://codereview.chromium.org/1642023002 TBR=martiniss BUG=582074 Review URL: https://codereview.chromium.org/1651033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298519 0039d316-1c4b-4281-b951-d872f2087c98
10 years ago
"@@@STEP_LOG_LINE@json.output@ }, @@@",
Reland "Remove obsolete bot_update flag" This reverts commit c91686c087704f3aeea594e6b7c82767fa7d753b. Reason for revert: Reland a light version of the original CL that keeps a dummy flag around. Original change's description: > Revert "Remove obsolete bot_update flag" > > This reverts commit 72048266d5cf68dc06c2cd20e173fbcb6f0dcfd2. > > Reason for revert: Skia depends on it. Need to clean that up first. Currently blocks roll: > https://skia-review.googlesource.com/c/14145/ > > Original change's description: > > Remove obsolete bot_update flag > > > > Using the manifest is the default since a long time. The flag was only introduced to smoothly switch it on. Now the flag is not needed anymore. > > > > Bug: 398105 > > Change-Id: I4eb1c98e26e025a69f8b0a7c48877d78c031702e > > Reviewed-on: https://chromium-review.googlesource.com/485659 > > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > > Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > > > TBR=phajdan.jr@chromium.org,machenbach@chromium.org,tandrii@chromium.org,sergiyb@chromium.org,chromium-reviews@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: Iffc4d8076abd3c92feebfd7f3ef88be7ce34b692 > Reviewed-on: https://chromium-review.googlesource.com/486639 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > R=phajdan.jr@chromium.org,machenbach@chromium.org,tandrii@chromium.org,sergiyb@chromium.org,chromium-reviews@chromium.org Bug: 398105 Change-Id: I817d446f8a8eff84c5d7143ac2b9c527a40991f1 Reviewed-on: https://chromium-review.googlesource.com/486640 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ \"manifest\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"src\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"repository\": \"https://fake.org/src.git\", @@@",
Use fixed revisions in bot_update's test API output_json. Currently the output_json method generates revisions for projects that are in the revision_mapping and only those projects appear in the manifest and source_manifest, using the generated revision. This method is used to construct the default json output for bot_update in tests. This has 2 problems: 1. If a project has a fixed revision, its manifest entries and the property used the generated revision, meaning the gitiles input revision will not be used in the json output. 2. If a project has a fixed revision and isn't present in revision_mapping then manifest entries aren't generated for it. This changes the method to use the revisions in the fixed_revisions dict and to create manifest entries for the projects that appear in the fixed_revisions dict which should make fewer situations where bot_update's output_json needs to be explicitly set. Change-Id: I99de52edc9248c28e9d3aa3a04cc77bf9fccbe37 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: chrome_release Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2304644 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
5 years ago
"@@@STEP_LOG_LINE@json.output@ \"revision\": \"2d72510e447ab60a9728aeea2362d8be2cbd7789\"@@@",
Query Gerrit for destination branch in bot_update This makes bot_update query Gerrit when syncing for Gerrit tryjobs. The query will establish the actual destination branch of the CL, which can be different from master (e.g. a feature branch). Bot_update will ensure to use this destination branch for the repo that corresponds to the CL's project. Both the main project or a deps'ed project work. Initially, this lives behind a flag that can be controlled in downstream recipes. Eventually we'll set this to default after a gradual roll-out. Branches in branch-heads are not supported yet. Bug: 740456 Change-Id: I4a0d50e2ca8fe90f8d29964a3ffab17291f7be60 Reviewed-on: https://chromium-review.googlesource.com/566824 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ }, @@@",
Fix bot_update example This adds angle to the got_revision_mapping to take account of the checked out revision and use it correctly in the without-patch application. This just adds the got_revision property to all test cases in the output and fixes the second bot_update run of two angle test cases. Bug: 740456 Change-Id: I6ae6bf627653280bc2a94230ec77949411dc4331 Reviewed-on: https://chromium-review.googlesource.com/573741 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ \"src/third_party/angle\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"repository\": \"https://fake.org/src/third_party/angle.git\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"revision\": \"fac9503c46405f77757b9a728eb85b8d7bc6080c\"@@@",
"@@@STEP_LOG_LINE@json.output@ }, @@@",
Query Gerrit for destination branch in bot_update This makes bot_update query Gerrit when syncing for Gerrit tryjobs. The query will establish the actual destination branch of the CL, which can be different from master (e.g. a feature branch). Bot_update will ensure to use this destination branch for the repo that corresponds to the CL's project. Both the main project or a deps'ed project work. Initially, this lives behind a flag that can be controlled in downstream recipes. Eventually we'll set this to default after a gradual roll-out. Branches in branch-heads are not supported yet. Bug: 740456 Change-Id: I4a0d50e2ca8fe90f8d29964a3ffab17291f7be60 Reviewed-on: https://chromium-review.googlesource.com/566824 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ \"src/v8\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"repository\": \"https://fake.org/src/v8.git\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"revision\": \"801ada225ddc271c132c3a35f03975671d43e399\"@@@",
Reland "Remove obsolete bot_update flag" This reverts commit c91686c087704f3aeea594e6b7c82767fa7d753b. Reason for revert: Reland a light version of the original CL that keeps a dummy flag around. Original change's description: > Revert "Remove obsolete bot_update flag" > > This reverts commit 72048266d5cf68dc06c2cd20e173fbcb6f0dcfd2. > > Reason for revert: Skia depends on it. Need to clean that up first. Currently blocks roll: > https://skia-review.googlesource.com/c/14145/ > > Original change's description: > > Remove obsolete bot_update flag > > > > Using the manifest is the default since a long time. The flag was only introduced to smoothly switch it on. Now the flag is not needed anymore. > > > > Bug: 398105 > > Change-Id: I4eb1c98e26e025a69f8b0a7c48877d78c031702e > > Reviewed-on: https://chromium-review.googlesource.com/485659 > > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > > Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > > > TBR=phajdan.jr@chromium.org,machenbach@chromium.org,tandrii@chromium.org,sergiyb@chromium.org,chromium-reviews@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: Iffc4d8076abd3c92feebfd7f3ef88be7ce34b692 > Reviewed-on: https://chromium-review.googlesource.com/486639 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > R=phajdan.jr@chromium.org,machenbach@chromium.org,tandrii@chromium.org,sergiyb@chromium.org,chromium-reviews@chromium.org Bug: 398105 Change-Id: I817d446f8a8eff84c5d7143ac2b9c527a40991f1 Reviewed-on: https://chromium-review.googlesource.com/486640 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@ }, @@@",
depot_tools: import bot_update gclient git rietveld tryserver recipe modules (reland #1) Previous attempt: https://codereview.chromium.org/1642023002 TBR=martiniss BUG=582074 Review URL: https://codereview.chromium.org/1651033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298519 0039d316-1c4b-4281-b951-d872f2087c98
10 years ago
"@@@STEP_LOG_LINE@json.output@ \"patch_failure\": false, @@@",
"@@@STEP_LOG_LINE@json.output@ \"patch_root\": \"src\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"properties\": {@@@",
Fix bot_update example This adds angle to the got_revision_mapping to take account of the checked out revision and use it correctly in the without-patch application. This just adds the got_revision property to all test cases in the output and fixes the second bot_update run of two angle test cases. Bug: 740456 Change-Id: I6ae6bf627653280bc2a94230ec77949411dc4331 Reviewed-on: https://chromium-review.googlesource.com/573741 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ \"got_angle_revision\": \"fac9503c46405f77757b9a728eb85b8d7bc6080c\", @@@",
Use main as default branch in all recipes Recipe-Manual-Change: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I89008bc07b1c3de13d9c6dd64e723fe6dc8d01d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3015262 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Gavin Mak <gavinmak@google.com> Reviewed-by: Anthony Polito <apolito@google.com>
4 years ago
"@@@STEP_LOG_LINE@json.output@ \"got_angle_revision_cp\": \"refs/heads/main@{#297276}\", @@@",
Use fixed revisions in bot_update's test API output_json. Currently the output_json method generates revisions for projects that are in the revision_mapping and only those projects appear in the manifest and source_manifest, using the generated revision. This method is used to construct the default json output for bot_update in tests. This has 2 problems: 1. If a project has a fixed revision, its manifest entries and the property used the generated revision, meaning the gitiles input revision will not be used in the json output. 2. If a project has a fixed revision and isn't present in revision_mapping then manifest entries aren't generated for it. This changes the method to use the revisions in the fixed_revisions dict and to create manifest entries for the projects that appear in the fixed_revisions dict which should make fewer situations where bot_update's output_json needs to be explicitly set. Change-Id: I99de52edc9248c28e9d3aa3a04cc77bf9fccbe37 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: chrome_release Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2304644 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
5 years ago
"@@@STEP_LOG_LINE@json.output@ \"got_cr_revision\": \"2d72510e447ab60a9728aeea2362d8be2cbd7789\", @@@",
Use main as default branch in all recipes Recipe-Manual-Change: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I89008bc07b1c3de13d9c6dd64e723fe6dc8d01d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3015262 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Gavin Mak <gavinmak@google.com> Reviewed-by: Anthony Polito <apolito@google.com>
4 years ago
"@@@STEP_LOG_LINE@json.output@ \"got_cr_revision_cp\": \"refs/heads/main@{#170242}\", @@@",
Use fixed revisions in bot_update's test API output_json. Currently the output_json method generates revisions for projects that are in the revision_mapping and only those projects appear in the manifest and source_manifest, using the generated revision. This method is used to construct the default json output for bot_update in tests. This has 2 problems: 1. If a project has a fixed revision, its manifest entries and the property used the generated revision, meaning the gitiles input revision will not be used in the json output. 2. If a project has a fixed revision and isn't present in revision_mapping then manifest entries aren't generated for it. This changes the method to use the revisions in the fixed_revisions dict and to create manifest entries for the projects that appear in the fixed_revisions dict which should make fewer situations where bot_update's output_json needs to be explicitly set. Change-Id: I99de52edc9248c28e9d3aa3a04cc77bf9fccbe37 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: chrome_release Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2304644 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
5 years ago
"@@@STEP_LOG_LINE@json.output@ \"got_revision\": \"2d72510e447ab60a9728aeea2362d8be2cbd7789\", @@@",
Use main as default branch in all recipes Recipe-Manual-Change: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I89008bc07b1c3de13d9c6dd64e723fe6dc8d01d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3015262 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Gavin Mak <gavinmak@google.com> Reviewed-by: Anthony Polito <apolito@google.com>
4 years ago
"@@@STEP_LOG_LINE@json.output@ \"got_revision_cp\": \"refs/heads/main@{#170242}\", @@@",
Query Gerrit for destination branch in bot_update This makes bot_update query Gerrit when syncing for Gerrit tryjobs. The query will establish the actual destination branch of the CL, which can be different from master (e.g. a feature branch). Bot_update will ensure to use this destination branch for the repo that corresponds to the CL's project. Both the main project or a deps'ed project work. Initially, this lives behind a flag that can be controlled in downstream recipes. Eventually we'll set this to default after a gradual roll-out. Branches in branch-heads are not supported yet. Bug: 740456 Change-Id: I4a0d50e2ca8fe90f8d29964a3ffab17291f7be60 Reviewed-on: https://chromium-review.googlesource.com/566824 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ \"got_v8_revision\": \"801ada225ddc271c132c3a35f03975671d43e399\", @@@",
Use main as default branch in all recipes Recipe-Manual-Change: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I89008bc07b1c3de13d9c6dd64e723fe6dc8d01d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3015262 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Gavin Mak <gavinmak@google.com> Reviewed-by: Anthony Polito <apolito@google.com>
4 years ago
"@@@STEP_LOG_LINE@json.output@ \"got_v8_revision_cp\": \"refs/heads/main@{#43426}\"@@@",
depot_tools: import bot_update gclient git rietveld tryserver recipe modules (reland #1) Previous attempt: https://codereview.chromium.org/1642023002 TBR=martiniss BUG=582074 Review URL: https://codereview.chromium.org/1651033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298519 0039d316-1c4b-4281-b951-d872f2087c98
10 years ago
"@@@STEP_LOG_LINE@json.output@ }, @@@",
"@@@STEP_LOG_LINE@json.output@ \"root\": \"src\", @@@",
Reland 2 "bot_update recipe: Upload source manifest" This relands commit 47b67c426b1d7120803e09f570e1cca312b34249. Also: * Fix bot_update.py output of manifest Bug: 772529,776299 Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: skiabuildbot Recipe-Nontrivial-Roll: release_scripts Recipe-Nontrivial-Roll: skia Recipe-Nontrivial-Roll: skiabuildbot Recipe-Nontrivial-Roll: build Change-Id: I31828ea5bfbc284623be8e553980f83d0889de92 Reviewed-on: https://chromium-review.googlesource.com/748308 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ \"source_manifest\": {@@@",
bot_update source manifest: fix test_api.py to match the actual output The test output was incorrect, this matches what it actually should look like. Bug: 772529 Change-Id: I1ca9ceeb6d6b6f55b2ac7c90667c6a9904d2a43b Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: skia Recipe-Nontrivial-Roll: release_scripts Change-Id: I1ca9ceeb6d6b6f55b2ac7c90667c6a9904d2a43b Reviewed-on: https://chromium-review.googlesource.com/751694 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ \"directories\": {@@@",
Reland 2 "bot_update recipe: Upload source manifest" This relands commit 47b67c426b1d7120803e09f570e1cca312b34249. Also: * Fix bot_update.py output of manifest Bug: 772529,776299 Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: skiabuildbot Recipe-Nontrivial-Roll: release_scripts Recipe-Nontrivial-Roll: skia Recipe-Nontrivial-Roll: skiabuildbot Recipe-Nontrivial-Roll: build Change-Id: I31828ea5bfbc284623be8e553980f83d0889de92 Reviewed-on: https://chromium-review.googlesource.com/748308 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ \"src\": {@@@",
bot_update source manifest: fix test_api.py to match the actual output The test output was incorrect, this matches what it actually should look like. Bug: 772529 Change-Id: I1ca9ceeb6d6b6f55b2ac7c90667c6a9904d2a43b Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: skia Recipe-Nontrivial-Roll: release_scripts Change-Id: I1ca9ceeb6d6b6f55b2ac7c90667c6a9904d2a43b Reviewed-on: https://chromium-review.googlesource.com/751694 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ \"git_checkout\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"repo_url\": \"https://fake.org/src.git\", @@@",
Use fixed revisions in bot_update's test API output_json. Currently the output_json method generates revisions for projects that are in the revision_mapping and only those projects appear in the manifest and source_manifest, using the generated revision. This method is used to construct the default json output for bot_update in tests. This has 2 problems: 1. If a project has a fixed revision, its manifest entries and the property used the generated revision, meaning the gitiles input revision will not be used in the json output. 2. If a project has a fixed revision and isn't present in revision_mapping then manifest entries aren't generated for it. This changes the method to use the revisions in the fixed_revisions dict and to create manifest entries for the projects that appear in the fixed_revisions dict which should make fewer situations where bot_update's output_json needs to be explicitly set. Change-Id: I99de52edc9248c28e9d3aa3a04cc77bf9fccbe37 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: chrome_release Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2304644 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
5 years ago
"@@@STEP_LOG_LINE@json.output@ \"revision\": \"2d72510e447ab60a9728aeea2362d8be2cbd7789\"@@@",
bot_update source manifest: fix test_api.py to match the actual output The test output was incorrect, this matches what it actually should look like. Bug: 772529 Change-Id: I1ca9ceeb6d6b6f55b2ac7c90667c6a9904d2a43b Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: skia Recipe-Nontrivial-Roll: release_scripts Change-Id: I1ca9ceeb6d6b6f55b2ac7c90667c6a9904d2a43b Reviewed-on: https://chromium-review.googlesource.com/751694 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ }@@@",
Reland 2 "bot_update recipe: Upload source manifest" This relands commit 47b67c426b1d7120803e09f570e1cca312b34249. Also: * Fix bot_update.py output of manifest Bug: 772529,776299 Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: skiabuildbot Recipe-Nontrivial-Roll: release_scripts Recipe-Nontrivial-Roll: skia Recipe-Nontrivial-Roll: skiabuildbot Recipe-Nontrivial-Roll: build Change-Id: I31828ea5bfbc284623be8e553980f83d0889de92 Reviewed-on: https://chromium-review.googlesource.com/748308 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ }, @@@",
"@@@STEP_LOG_LINE@json.output@ \"src/third_party/angle\": {@@@",
bot_update source manifest: fix test_api.py to match the actual output The test output was incorrect, this matches what it actually should look like. Bug: 772529 Change-Id: I1ca9ceeb6d6b6f55b2ac7c90667c6a9904d2a43b Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: skia Recipe-Nontrivial-Roll: release_scripts Change-Id: I1ca9ceeb6d6b6f55b2ac7c90667c6a9904d2a43b Reviewed-on: https://chromium-review.googlesource.com/751694 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ \"git_checkout\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"repo_url\": \"https://fake.org/src/third_party/angle.git\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"revision\": \"fac9503c46405f77757b9a728eb85b8d7bc6080c\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
Reland 2 "bot_update recipe: Upload source manifest" This relands commit 47b67c426b1d7120803e09f570e1cca312b34249. Also: * Fix bot_update.py output of manifest Bug: 772529,776299 Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: skiabuildbot Recipe-Nontrivial-Roll: release_scripts Recipe-Nontrivial-Roll: skia Recipe-Nontrivial-Roll: skiabuildbot Recipe-Nontrivial-Roll: build Change-Id: I31828ea5bfbc284623be8e553980f83d0889de92 Reviewed-on: https://chromium-review.googlesource.com/748308 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ }, @@@",
"@@@STEP_LOG_LINE@json.output@ \"src/v8\": {@@@",
bot_update source manifest: fix test_api.py to match the actual output The test output was incorrect, this matches what it actually should look like. Bug: 772529 Change-Id: I1ca9ceeb6d6b6f55b2ac7c90667c6a9904d2a43b Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: skia Recipe-Nontrivial-Roll: release_scripts Change-Id: I1ca9ceeb6d6b6f55b2ac7c90667c6a9904d2a43b Reviewed-on: https://chromium-review.googlesource.com/751694 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ \"git_checkout\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"repo_url\": \"https://fake.org/src/v8.git\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"revision\": \"801ada225ddc271c132c3a35f03975671d43e399\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
Reland 2 "bot_update recipe: Upload source manifest" This relands commit 47b67c426b1d7120803e09f570e1cca312b34249. Also: * Fix bot_update.py output of manifest Bug: 772529,776299 Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: skiabuildbot Recipe-Nontrivial-Roll: release_scripts Recipe-Nontrivial-Roll: skia Recipe-Nontrivial-Roll: skiabuildbot Recipe-Nontrivial-Roll: build Change-Id: I31828ea5bfbc284623be8e553980f83d0889de92 Reviewed-on: https://chromium-review.googlesource.com/748308 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
8 years ago
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@ }, @@@",
"@@@STEP_LOG_LINE@json.output@ \"version\": 0@@@",
"@@@STEP_LOG_LINE@json.output@ }, @@@",
depot_tools: import bot_update gclient git rietveld tryserver recipe modules (reland #1) Previous attempt: https://codereview.chromium.org/1642023002 TBR=martiniss BUG=582074 Review URL: https://codereview.chromium.org/1651033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298519 0039d316-1c4b-4281-b951-d872f2087c98
10 years ago
"@@@STEP_LOG_LINE@json.output@ \"step_text\": \"Some step text\"@@@",
"@@@STEP_LOG_LINE@json.output@}@@@",
"@@@STEP_LOG_END@json.output@@@",
Fix bot_update example This adds angle to the got_revision_mapping to take account of the checked out revision and use it correctly in the without-patch application. This just adds the got_revision property to all test cases in the output and fixes the second bot_update run of two angle test cases. Bug: 740456 Change-Id: I6ae6bf627653280bc2a94230ec77949411dc4331 Reviewed-on: https://chromium-review.googlesource.com/573741 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
8 years ago
"@@@SET_BUILD_PROPERTY@got_angle_revision@\"fac9503c46405f77757b9a728eb85b8d7bc6080c\"@@@",
Use main as default branch in all recipes Recipe-Manual-Change: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I89008bc07b1c3de13d9c6dd64e723fe6dc8d01d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3015262 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Gavin Mak <gavinmak@google.com> Reviewed-by: Anthony Polito <apolito@google.com>
4 years ago
"@@@SET_BUILD_PROPERTY@got_angle_revision_cp@\"refs/heads/main@{#297276}\"@@@",
Use fixed revisions in bot_update's test API output_json. Currently the output_json method generates revisions for projects that are in the revision_mapping and only those projects appear in the manifest and source_manifest, using the generated revision. This method is used to construct the default json output for bot_update in tests. This has 2 problems: 1. If a project has a fixed revision, its manifest entries and the property used the generated revision, meaning the gitiles input revision will not be used in the json output. 2. If a project has a fixed revision and isn't present in revision_mapping then manifest entries aren't generated for it. This changes the method to use the revisions in the fixed_revisions dict and to create manifest entries for the projects that appear in the fixed_revisions dict which should make fewer situations where bot_update's output_json needs to be explicitly set. Change-Id: I99de52edc9248c28e9d3aa3a04cc77bf9fccbe37 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: chrome_release Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2304644 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
5 years ago
"@@@SET_BUILD_PROPERTY@got_cr_revision@\"2d72510e447ab60a9728aeea2362d8be2cbd7789\"@@@",
Use main as default branch in all recipes Recipe-Manual-Change: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I89008bc07b1c3de13d9c6dd64e723fe6dc8d01d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3015262 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Gavin Mak <gavinmak@google.com> Reviewed-by: Anthony Polito <apolito@google.com>
4 years ago
"@@@SET_BUILD_PROPERTY@got_cr_revision_cp@\"refs/heads/main@{#170242}\"@@@",
Use fixed revisions in bot_update's test API output_json. Currently the output_json method generates revisions for projects that are in the revision_mapping and only those projects appear in the manifest and source_manifest, using the generated revision. This method is used to construct the default json output for bot_update in tests. This has 2 problems: 1. If a project has a fixed revision, its manifest entries and the property used the generated revision, meaning the gitiles input revision will not be used in the json output. 2. If a project has a fixed revision and isn't present in revision_mapping then manifest entries aren't generated for it. This changes the method to use the revisions in the fixed_revisions dict and to create manifest entries for the projects that appear in the fixed_revisions dict which should make fewer situations where bot_update's output_json needs to be explicitly set. Change-Id: I99de52edc9248c28e9d3aa3a04cc77bf9fccbe37 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: chrome_release Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2304644 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
5 years ago
"@@@SET_BUILD_PROPERTY@got_revision@\"2d72510e447ab60a9728aeea2362d8be2cbd7789\"@@@",
Use main as default branch in all recipes Recipe-Manual-Change: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I89008bc07b1c3de13d9c6dd64e723fe6dc8d01d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3015262 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Gavin Mak <gavinmak@google.com> Reviewed-by: Anthony Polito <apolito@google.com>
4 years ago
"@@@SET_BUILD_PROPERTY@got_revision_cp@\"refs/heads/main@{#170242}\"@@@",
Query Gerrit for destination branch in bot_update This makes bot_update query Gerrit when syncing for Gerrit tryjobs. The query will establish the actual destination branch of the CL, which can be different from master (e.g. a feature branch). Bot_update will ensure to use this destination branch for the repo that corresponds to the CL's project. Both the main project or a deps'ed project work. Initially, this lives behind a flag that can be controlled in downstream recipes. Eventually we'll set this to default after a gradual roll-out. Branches in branch-heads are not supported yet. Bug: 740456 Change-Id: I4a0d50e2ca8fe90f8d29964a3ffab17291f7be60 Reviewed-on: https://chromium-review.googlesource.com/566824 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
"@@@SET_BUILD_PROPERTY@got_v8_revision@\"801ada225ddc271c132c3a35f03975671d43e399\"@@@",
Use main as default branch in all recipes Recipe-Manual-Change: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I89008bc07b1c3de13d9c6dd64e723fe6dc8d01d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3015262 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Gavin Mak <gavinmak@google.com> Reviewed-by: Anthony Polito <apolito@google.com>
4 years ago
"@@@SET_BUILD_PROPERTY@got_v8_revision_cp@\"refs/heads/main@{#43426}\"@@@"
depot_tools: import bot_update gclient git rietveld tryserver recipe modules (reland #1) Previous attempt: https://codereview.chromium.org/1642023002 TBR=martiniss BUG=582074 Review URL: https://codereview.chromium.org/1651033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298519 0039d316-1c4b-4281-b951-d872f2087c98
10 years ago
]
},
[bot_update] Use got_revision for output commit got_revision and got_revision_cp point to the commit that Build.output.gitiles_commit should point to. Therefore, derive output commit from these properties. Derive output ref from got_revision_cp if it available. Otherwise, try to read it from input commit Bug: 940214 Change-Id: I108d782ad93c70114581830d7427b95d3efd9d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1588506 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
6 years ago
{
"cmd": [],
"name": "set_output_gitiles_commit",
"~followup_annotations": [
Use main as default branch in all recipes Recipe-Manual-Change: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I89008bc07b1c3de13d9c6dd64e723fe6dc8d01d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3015262 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Gavin Mak <gavinmak@google.com> Reviewed-by: Anthony Polito <apolito@google.com>
4 years ago
"@@@SET_BUILD_PROPERTY@$recipe_engine/buildbucket/output_gitiles_commit@{\"host\": \"fake.org\", \"id\": \"2d72510e447ab60a9728aeea2362d8be2cbd7789\", \"position\": 170242, \"project\": \"src\", \"ref\": \"refs/heads/main\"}@@@"
[bot_update] Use got_revision for output commit got_revision and got_revision_cp point to the commit that Build.output.gitiles_commit should point to. Therefore, derive output commit from these properties. Derive output ref from got_revision_cp if it available. Otherwise, try to read it from input commit Bug: 940214 Change-Id: I108d782ad93c70114581830d7427b95d3efd9d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1588506 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
6 years ago
]
},
depot_tools: import bot_update gclient git rietveld tryserver recipe modules (reland #1) Previous attempt: https://codereview.chromium.org/1642023002 TBR=martiniss BUG=582074 Review URL: https://codereview.chromium.org/1651033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298519 0039d316-1c4b-4281-b951-d872f2087c98
10 years ago
{
Manual roll for new run logic Manual roll for https://crrev.com/c/1239574/ TBR=iannucci Recipe-Manual-Change: build Recipe-Manual-Change: infra Recipe-Manual-Change: build_limited_scripts_slave Recipe-Manual-Change: release_scripts Recipe-Manual-Change: skiabuildbot Recipe-Manual-Change: skia Bug: 646142 Change-Id: I56f156c05a695cfb00b9e0a7f335d516153a70c7 Reviewed-on: https://chromium-review.googlesource.com/c/1305041 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
7 years ago
"name": "$result"
depot_tools: import bot_update gclient git rietveld tryserver recipe modules (reland #1) Previous attempt: https://codereview.chromium.org/1642023002 TBR=martiniss BUG=582074 Review URL: https://codereview.chromium.org/1651033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298519 0039d316-1c4b-4281-b951-d872f2087c98
10 years ago
}
]