From b1448d95e5cf8c6509e3e1356debe4b3db291527 Mon Sep 17 00:00:00 2001 From: Isaac Abadi Date: Thu, 23 Jun 2022 01:44:19 -0400 Subject: [PATCH] Added resolution and audio bitrate to video info dialog --- Public API v1.yaml | 6 ++++ src/api-types/models/DatabaseFile.ts | 8 +++++ .../video-info-dialog.component.html | 8 +++++ src/app/player/player.component.ts | 8 +++-- src/assets/i18n/messages.en.xlf | 30 ++++++++++++++----- 5 files changed, 51 insertions(+), 9 deletions(-) diff --git a/Public API v1.yaml b/Public API v1.yaml index 860c054..37b9f1f 100644 --- a/Public API v1.yaml +++ b/Public API v1.yaml @@ -2425,6 +2425,12 @@ components: type: string registered: type: number + height: + type: number + description: In pixels, only for videos + abr: + type: number + description: In Kbps Playlist: required: - uids diff --git a/src/api-types/models/DatabaseFile.ts b/src/api-types/models/DatabaseFile.ts index bfe8cb4..f36af9e 100644 --- a/src/api-types/models/DatabaseFile.ts +++ b/src/api-types/models/DatabaseFile.ts @@ -32,4 +32,12 @@ export type DatabaseFile = { local_view_count?: number; sub_id?: string; registered?: number; + /** + * In pixels, only for videos + */ + height?: number; + /** + * In Kbps + */ + abr?: number; }; \ No newline at end of file diff --git a/src/app/dialogs/video-info-dialog/video-info-dialog.component.html b/src/app/dialogs/video-info-dialog/video-info-dialog.component.html index 8f99be9..d30862c 100644 --- a/src/app/dialogs/video-info-dialog/video-info-dialog.component.html +++ b/src/app/dialogs/video-info-dialog/video-info-dialog.component.html @@ -47,6 +47,14 @@ +
+
Resolution: 
+
{{new_file.height ? new_file.height + 'p' : 'N/A'}}
+
+
+
Audio bitrate: 
+
{{new_file.abr ? new_file.abr + ' Kbps' : 'N/A'}}
+
File size: 
{{new_file.size ? filesize(new_file.size) : 'N/A'}}
diff --git a/src/app/player/player.component.ts b/src/app/player/player.component.ts index 053e931..4cba6c5 100644 --- a/src/app/player/player.component.ts +++ b/src/app/player/player.component.ts @@ -361,12 +361,16 @@ export class PlayerComponent implements OnInit, AfterViewInit, OnDestroy { } openFileInfoDialog(): void { - this.dialog.open(VideoInfoDialogComponent, { + const dialogRef = this.dialog.open(VideoInfoDialogComponent, { data: { file: this.db_file, }, minWidth: '50vw' - }) + }); + + dialogRef.afterClosed().subscribe(() => { + this.db_file = dialogRef.componentInstance.file; + }); } setPlaybackTimestamp(time: number): void { diff --git a/src/assets/i18n/messages.en.xlf b/src/assets/i18n/messages.en.xlf index 5c40019..a7ea877 100644 --- a/src/assets/i18n/messages.en.xlf +++ b/src/assets/i18n/messages.en.xlf @@ -641,7 +641,7 @@ src/app/dialogs/video-info-dialog/video-info-dialog.component.html - 62 + 70 Close @@ -745,7 +745,7 @@ src/app/dialogs/video-info-dialog/video-info-dialog.component.html - 63 + 71 src/app/settings/settings.component.html @@ -2154,11 +2154,27 @@ Local view count + + Resolution: + + src/app/dialogs/video-info-dialog/video-info-dialog.component.html + 51 + + Video resolution property + + + Audio bitrate: + + src/app/dialogs/video-info-dialog/video-info-dialog.component.html + 55 + + Video audio bitrate property + File size: src/app/dialogs/video-info-dialog/video-info-dialog.component.html - 51 + 59 Video file size property @@ -2166,7 +2182,7 @@ Path: src/app/dialogs/video-info-dialog/video-info-dialog.component.html - 55 + 63 Video path property @@ -2352,18 +2368,18 @@ Failed to get file information from the server. src/app/player/player.component.ts - 150 + 149 Failed to load playlist! src/app/player/player.component.ts - 187 + 186 src/app/player/player.component.ts - 190 + 189