From e1cc03045dbbcbb8b5e85ed2af25dd09bf2bd39c Mon Sep 17 00:00:00 2001
From: Gilbert Gilb's <gilbsgilbert@gmail.com>
Date: Wed, 30 Mar 2022 19:09:00 +0200
Subject: [PATCH] Add F-Droid build flavor.

We need a different build flavor for F-Droid because they forbid
auto-updaters as they download blobs from the internet (and it wouldn't
be possible to install the downloaded APK anyways because of the
signatures mismatch).

I chose to implement this using a build config field instead of using a
per-build-flavor source directory because I thought it introduces less
maintenance burden. In particular, per-build-flavor source directories
would require an interface in the main source directory for the update
manager, which would be implemented for each build flavor in a specific
source directory. Considering this project doesn't have CI builds yet, I
think it wouldn't be wise. Still we might reconsider should we need more
complex setup (such as different dependencies for the two build
flavors). The main downside of the build config field for now is that it
may be more prone to silent regressions.

Fixes #41
---
 app/build.gradle                              | 19 +++++++++++++++++++
 .../com/fox2code/mmm/AppUpdateManager.java    |  2 ++
 2 files changed, 21 insertions(+)

diff --git a/app/build.gradle b/app/build.gradle
index f58186c..cb71ef2 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -28,6 +28,25 @@ android {
             debuggable true
         }
     }
+
+    flavorDimensions "type"
+    productFlavors {
+        "default" {
+            dimension "type"
+            buildConfigField "boolean", "ENABLE_AUTO_UPDATER", "true"
+        }
+
+        fdroid {
+            dimension "type"
+            applicationIdSuffix ".fdroid"
+
+            // Need to disable auto-updater for F-Droid flavor because their inclusion policy
+            // forbids downloading blobs from third-party websites (and F-Droid APK isn't signed
+            // with our keys, so the APK wouldn't install anyways).
+            buildConfigField "boolean", "ENABLE_AUTO_UPDATER", "false"
+        }
+    }
+
     compileOptions {
         sourceCompatibility JavaVersion.VERSION_1_8
         targetCompatibility JavaVersion.VERSION_1_8
diff --git a/app/src/main/java/com/fox2code/mmm/AppUpdateManager.java b/app/src/main/java/com/fox2code/mmm/AppUpdateManager.java
index 4a043d7..62acff2 100644
--- a/app/src/main/java/com/fox2code/mmm/AppUpdateManager.java
+++ b/app/src/main/java/com/fox2code/mmm/AppUpdateManager.java
@@ -63,6 +63,8 @@ public class AppUpdateManager {
 
     // Return true if should show a notification
     public boolean checkUpdate(boolean force) {
+        if (!BuildConfig.ENABLE_AUTO_UPDATER)
+            return false;
         if (!force && this.peekShouldUpdate())
             return true;
         long lastChecked = this.lastChecked;